lights() and specularMaterial() support on framebuffer block when filter is applied inside the block. - #6596
Merged
Conversation
Collaborator
Author
|
This was an oversight when we solved the issue #6559 |
davepagurek
approved these changes
Nov 30, 2023
davepagurek
left a comment
davepagurek
left a comment
Contributor
There was a problem hiding this comment.
Thanks for catching this!
Collaborator
Author
Yess... Thanks❤ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6595
Changes:
This pull request addresses the inconsistency observed when using lights() and specularmaterial() within the framebuffer block, specifically when the filter() function is applied internally. The proposed changes ensure that lights and materials behave as expected within the framebuffer block, enhancing overall rendering consistency.
Screenshots of the change:
before:-
after:-
PR Checklist
npm run lintpasses