Update default values in ortho() docs, use default args in example - #6758
Merged
Conversation
Contributor
Author
|
@diyaayay since you updated this example last, let me know if you think these changes make sense to you! |
Contributor
|
@davepagurek Yes, I think these work well now. I should have updated the documentation while adding 800 to the default |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6755
Changes
farvalue adds 800orthoin the example:farvalue wasn't suitable when copy-and-pasted into a larger sketchcamera(...)call: with the updatedfarvalue, the camera does not need to be placed closer to the objects to make them visible and have them continue to be visible when zooming/rotating a bit withorbitControlScreenshots of the change
Before:

After:

PR Checklist
npm run lintpasses