Skip to content

Update default values in ortho() docs, use default args in example - #6758

Merged
davepagurek merged 2 commits into
mainfrom
fix/ortho-example
Jan 26, 2024
Merged

Update default values in ortho() docs, use default args in example#6758
davepagurek merged 2 commits into
mainfrom
fix/ortho-example

Conversation

@davepagurek

@davepagurek davepagurek commented Jan 21, 2024

Copy link
Copy Markdown
Contributor

Resolves #6755

Changes

  • Updates the documentation to mention that the default far value adds 800
  • Removes the args from ortho in the example:
    • Its default far value wasn't suitable when copy-and-pasted into a larger sketch
    • Its y values were flipped vertically, also probably unexpected when copy-and-pasting
  • Removes the camera(...) call: with the updated far value, the camera does not need to be placed closer to the objects to make them visible and have them continue to be visible when zooming/rotating a bit with orbitControl

Screenshots of the change

Before:
image

After:
image

PR Checklist

@davepagurek

Copy link
Copy Markdown
Contributor Author

@diyaayay since you updated this example last, let me know if you think these changes make sense to you!

@diyaayay

Copy link
Copy Markdown
Contributor

@davepagurek Yes, I think these work well now. I should have updated the documentation while adding 800 to the default far value.
Thanks for looking into this.

@davepagurek
davepagurek merged commit 3d45ce9 into main Jan 26, 2024
@davepagurek
davepagurek deleted the fix/ortho-example branch January 26, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ortho() rendering blank canvas

2 participants