Add keycode fes warning#8238
Conversation
|
🎉 Thanks for opening this pull request! For guidance on contributing, check out our contributor guidelines and other resources for contributors! Thank You! |
|
Hi! |
|
@ksen0, let me know if any changes are needed. |
|
Hi @ksen0, just a gentle follow-up on this PR. |
|
Hi @a-y-a-n-das thanks for making the PR! Sorry it fell through the cracks (part of the purpose of "wait for assignment" policy is to avoid missing these, since there are hundreds of notifications). Will take a look in the next days. |
|
@a-y-a-n-das actually before digging further I see already this PR targets the |
Resolves #7876
Changes:
keyCodeusage insrc/core/main.js.keyCodeis deprecated and suggests usingkeyIsDown()instead.test/manual-test-examples/events/keyCode-warning.htmlandtest/manual-test-examples/events/keyCode-warning-sketch.jsScreenshots of the change:
PR Checklist
npm run lintpasses