Skip to content

Add keycode fes warning#8238

Open
a-y-a-n-das wants to merge 2 commits into
processing:v1from
a-y-a-n-das:add-keycode-fes-warning
Open

Add keycode fes warning#8238
a-y-a-n-das wants to merge 2 commits into
processing:v1from
a-y-a-n-das:add-keycode-fes-warning

Conversation

@a-y-a-n-das

Copy link
Copy Markdown

Resolves #7876

Changes:

  • Added a one-time Friendly Error System (FES) warning for keyCode usage in src/core/main.js.
    • The warning informs users that keyCode is deprecated and suggests using keyIsDown() instead.
  • Added a manual test files: test/manual-test-examples/events/keyCode-warning.html and test/manual-test-examples/events/keyCode-warning-sketch.js
    • Verifies that the warning appears once and key behavior remains unchanged.

Screenshots of the change:

image

PR Checklist

@welcome

welcome Bot commented Nov 7, 2025

Copy link
Copy Markdown

🎉 Thanks for opening this pull request! For guidance on contributing, check out our contributor guidelines and other resources for contributors!
🤔 Please ensure that your PR links to an issue, which has been approved for work by a maintainer; otherwise, there might already be someone working on it, or still ongoing discussion about implementation. You are welcome to join the discussion in an Issue if you're not sure!
🌸 Once your PR is merged, be sure to add yourself to the list of contributors on the readme page !

Thank You!

@a-y-a-n-das

Copy link
Copy Markdown
Author

Hi!
I realized I should’ve claimed this issue first (as per the contributing guidelines), but since it wasn’t assigned to anyone and was still open, I went ahead and fixed it.
Hope that’s okay — please review when you get a chance. I can make any necessary adjustments if needed. 😊

@ksen0
ksen0 self-requested a review November 7, 2025 19:16
@a-y-a-n-das

a-y-a-n-das commented Dec 6, 2025

Copy link
Copy Markdown
Author

@ksen0, let me know if any changes are needed.

@a-y-a-n-das

Copy link
Copy Markdown
Author

Hi @ksen0, just a gentle follow-up on this PR.
Please let me know if there’s anything I should update or adjust to help move it forward.
Thanks, and I appreciate your time.

@ksen0

ksen0 commented Jun 17, 2026

Copy link
Copy Markdown
Member

Hi @a-y-a-n-das thanks for making the PR! Sorry it fell through the cracks (part of the purpose of "wait for assignment" policy is to avoid missing these, since there are hundreds of notifications). Will take a look in the next days.

@ksen0

ksen0 commented Jun 17, 2026

Copy link
Copy Markdown
Member

@a-y-a-n-das actually before digging further I see already this PR targets the v1 branch (previously it was main), but should target main (previously it was 2.0). Please check the original issue discussion, the problem is specifically about version 2.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add FES warning for keyCode === usage to help transition from 1.x to 2.0

2 participants