Expect private tags

[ksen0]

Fixes #8980

Local test npm run custom:dev ../p5-20/p5.js#priv

[p5-bot]

Continuous Release

CDN link

• https://raw.esm.sh/pr/p5@f53c60a/lib/p5.min.js

Published Packages

• https://pkg.pr.new/p5@f53c60a

Commit hash: d3aadd9

Previous deployments

6793b1e

• https://raw.esm.sh/pr/p5@b2e07dd/lib/p5.min.js
• https://pkg.pr.new/p5@b2e07dd

6558987

• https://raw.esm.sh/pr/p5@16f8666/lib/p5.min.js
• https://pkg.pr.new/p5@16f8666

4a3a029

• https://raw.esm.sh/pr/p5@8f5887d/lib/p5.min.js
• https://pkg.pr.new/p5@8f5887d

e4149ed

• https://raw.esm.sh/pr/p5@cc13b7f/lib/p5.min.js
• https://pkg.pr.new/p5@cc13b7f

---

This is an automated message.

[ksen0]

@limzykenneth stuck here. The original commit here fixed the reference docs but broke the tests.

So I am trying to add an "hidden" metadata that parsers/reference.ts could use to exclude but now I can't reproduce the original problem and also the tests still fail.

To be honest my mental model here makes no sense. I expect the p5.js data.json to match what p5.js-website builds and when I was getting the errors, it didn't match (on main on both, cleaned up). Now that's not happening either; I am not ruling out some kind of leftover data somewhere but I was manually deleting any left over reference artifacts.

I can sort of understand why changing exclusion rules in convert would break tests but I definitely dont understand why adding some metadata would.

Stopping here for the day, if you have any ideas would be helpful

[perminder-17]

Hi @ksen0 , regarding the test concern, I think the failing test was this one:

p5.js/test/unit/webgl/p5.Framebuffer.js

Lines 672 to 686 in a350bb3

	suite('saveCanvas', function() {
	test('should download a png file', async () => {
	myp5.createCanvas(100, 100, myp5.WEBGL);
	const fbo = myp5.createFramebuffer();
	fbo.draw(() => myp5.background('red'));
	myp5.saveCanvas(fbo);
	await new Promise(res => setTimeout(res, 500));
	expect(document.createElement).toHaveBeenCalledWith('a');
	expect(mockAnchorElement.click).toHaveBeenCalledTimes(1);
	assert.equal(mockAnchorElement.download, 'untitled.png');
	});
	});
	});

I reran the tests twice, and it passes now. I also remember discussing this particular test with Ken on Discord in the group. I'll take a look at fixing it, but for now I don't think it's related to your changes.

I observed that a test is flaky and occasionally fail (6 out of 10 times on an average) when executed in GitHub Actions.

[limzykenneth]

@ksen0 I had a look, so from what I can see, everything is actually working as intended currently. The reason for the original issue showing the private makeGuardedCallbacks entry in the website build is because the website build automatically fetches the known version the repo is tagged with in src/globals/p5-version.ts and that currently points to 2.3.0. Checking out 2.3.0 in the p5.js repo where makeGuardedCallbacks is called, it is not marked as private, ie. before your commit marking it as private. Which means if we build the website against 2.3.0 which by default it does, it will continue to show the functions even though it has been marked private in the latest commit or RC release.

The website can be made to build against an RC version by just replacing the 2.3.0 version number in src/globals/p5-version.ts to 2.3.0-rc.2.

In other words, I think there's nothing to fix here, we can try to make building against specific version of the p5.js repo by the website easier.

[ksen0]

Thanks for explaining @limzykenneth . I did npm run build:reference with export const p5Version = "2.3.1-rc.2" as const; and indeed the private methods are not there.