Created a loading indicator when the canvas is being set up#8997
Open
Jextic wants to merge 3 commits into
Open
Created a loading indicator when the canvas is being set up#8997Jextic wants to merge 3 commits into
Jextic wants to merge 3 commits into
Conversation
Member
|
Hi @Jextic thanks for putting this together and sorry for the long time to get to your comment, but please check the comment on the issue. If possible, to keep (1) non text based and (2) decoupled. I will be able to review this more deeply next week as well. Thanks for your work on this! |
Continuous ReleaseCDN linkPublished PackagesCommit hash: a14c933 Previous deploymentsThis is an automated message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8922
Changes:
showLoadingIndicator()is called, a div element with a "Loading..." text will be created. WhenhideLoadingIndicator()is called, the div element will be removed from the DOM.showLoadingIndicator()andhideLoadingIndicator()are called before and afterawait context.setup(). The loading indicators will only appear while the canvas is loading thesetup()function in sketch.js.Screenshots of the change:
All tests, including loading.js, pass. The only exception is a typography which always failed, even before changes were made to the project.
PR Checklist
npm run lintpassesAlso worked with @joshin on this issue.