Rewrite async tests without 3rd party library

[DaleSeo]

What kind of change does this PR introduce?

I recently learned that it's been much easier to write unit tests against asynchronous code in Python 3.8.

This PR rewrites the tests for the execute_async method using IsolatedAsyncioTestCase and AsyncMock of the standard unittest module. This also results in the asynctest dependency removed from the project.

What is the current behavior?

No changes in behavior

What is the new behavior?

No changes in behavior

Does this PR introduce a breaking change?

No

Other information

• IsolatedAsyncioTestCase
• AsyncMock

[DaleSeo]

@steve148 Do you have any idea why the linter fails on Github Actions when it passes locally? 🤷‍♂

[steve148]

@DaleSeo sorry for the late reply here. The CI checks failing is my fault, the pre-commit check should include the flake8-isort as a dependency of the flake8 check. I'm creating a fix for that in a sec, to fix it in your case you can install flake8-isort locally and you should get the flake8 error listed in the github action CI check.

pip install flake8-isort
flake8

[steve148]

Side note, for the next PR can you make sure it's coming from a fork of the repository? Right now you have write access to the repo and therefore you can create branches directly within the repo, but if we're expecting other people in the long run to fork for contributing we should also follow that standard. Let me know if you need any help for getting the fork setup for the next PR.

[steve148]

#22 should fix the issue you're seeing here where local linter checks don't match the remote checks.

[DaleSeo]

Side note, for the next PR can you make sure it's coming from a fork of the repository? Right now you have write access to the repo and therefore you can create branches directly within the repo, but if we're expecting other people in the long run to fork for contributing we should also follow that standard. Let me know if you need any help for getting the fork setup for the next PR.

👍 Got it! I'll work on a fork for the future PRs.

[DaleSeo]

I'll rebase it onto master once PR #22 gets merged.

[steve148]

Good stuff @DaleSeo! Once you've rebased we can merge the changes in.

[DaleSeo]

@steve148 I've rebased and sorted the imports in test_graphql_client.py using the isort CLI but the linter kept complaining as seen below.

I didn't know what to do so I just tried to commit with the --no-verify option to see if these changes happen to pass the linter on Github Actions and they passed. 🤷‍♂ It seems like there are still discrepancies between the pre-commit hook and the Github Actions workflow somehow. 🙁