fix: expose sh1pt init as top-level command#331
Open
nguyenlnp wants to merge 1 commit into
Open
Conversation
The README documents as the way to scaffold a project, but the CLI only registered it as . This change: - Extracts the init action into a shared initAction function in packages/cli/src/commands/init.ts - Registers as a top-level command in index.ts - Refactors ship.ts to import initAction from init.ts, keeping working as before Both and now work identically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #241
The README documents
sh1pt initas the way to scaffold a new project, but the CLI only registered it as a subcommand undersh1pt ship init.Changes
packages/cli/src/commands/init.ts— exportsinitCmd(top-level) andinitAction(shared logic)packages/cli/src/index.ts— imports and registersinitCmdas a top-level commandpackages/cli/src/commands/ship.ts— importsinitActionfrominit.tsinstead of defining the action inline, sosh1pt ship initstill worksBehavior
Both commands now work identically:
Testing
All 1887 tests pass (
pnpm test).SOL wallet:
0xadf380b5048e9730af0957fd39d5ef1de374475d