Skip to content

Log the error when UpdateUTCTime fails.#31880

Merged
mergify[bot] merged 1 commit intoproject-chip:masterfrom
bzbarsky-apple:log-time-set-error
Feb 2, 2024
Merged

Log the error when UpdateUTCTime fails.#31880
mergify[bot] merged 1 commit intoproject-chip:masterfrom
bzbarsky-apple:log-time-set-error

Conversation

@bzbarsky-apple
Copy link
Copy Markdown
Contributor

@bzbarsky-apple bzbarsky-apple commented Feb 2, 2024

Saying "error" without saying which error is a bit hostile to log-based debugging.

@bzbarsky-apple
Log the error when UpdateUTCTime fails.
9665a4a 
Saying "error" without saying which error is a bit hostile to log-based
debugging.
@github-actions github-actions bot added the app label Feb 2, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 2, 2024 •
edited
Loading

PR #31880: Size comparison from 4d89506 to 9665a4a

Increases (7 builds for esp32, linux, nrfconnect, telink)
platform target config section 4d89506 9665a4a change % change
esp32 all-clusters-app c3devkit (read only) 1201486 1201488 2 0.0
(read/write) 1747080 1747088 8 0.0
.flash.rodata 250360 250368 8 0.0
.flash.text 1201486 1201488 2 0.0
m5stack (read/write) 532012 532020 8 0.0
.flash.rodata 280496 280504 8 0.0
linux all-clusters-app debug (read only) 5842801 5842817 16 0.0
.text 5065475 5065491 16 0.0
shell debug (read only) 2856817 2856833 16 0.0
.text 2497682 2497698 16 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1094164 1094168 4 0.0
rodata 111636 111640 4 0.0
text 804896 804900 4 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 1111924 1111936 12 0.0
text 786328 786330 2 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read/write) 984628 984632 4 0.0
text 699334 699336 2 0.0
Decreases (1 build for efr32)
platform target config section 4d89506 9665a4a change % change
efr32 lighting-app BRD4161A+rs9116 (read/write) 928280 928272 -8 -0.0
.text 728976 728968 -8 -0.0
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
platform target config section 4d89506 9665a4a change % change
bl602 lighting-app bl602 (read/write) 1429522 1429522 0 0.0
.bss 85328 85328 0 0.0
.data 9488 9488 0 0.0
.rodata 157356 157356 0 0.0
.text 1096712 1096712 0 0.0
bl602+mfd (read/write) 1444170 1444170 0 0.0
.bss 85488 85488 0 0.0
.data 9456 9456 0 0.0
.rodata 156316 156316 0 0.0
.text 1112268 1112268 0 0.0
bl602+rpc (read/write) 1477162 1477162 0 0.0
.bss 93360 93360 0 0.0
.data 9856 9856 0 0.0
.rodata 164932 164932 0 0.0
.text 1128354 1128354 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1194319 1194319 0 0.0
.bss 11121 11121 0 0.0
.data 3664 3664 0 0.0
.rodata 106744 106744 0 0.0
.text 965970 965970 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1205395 1205395 0 0.0
.bss 11297 11297 0 0.0
.data 3648 3648 0 0.0
.rodata 105684 105684 0 0.0
.text 977978 977978 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1286067 1286067 0 0.0
.bss 19589 19589 0 0.0
.data 4216 4216 0 0.0
.rodata 122116 122116 0 0.0
.text 1040914 1040914 0 0.0
bl706-eth (read/write) 1012725 1012725 0 0.0
.bss 23680 23680 0 0.0
.data 3240 3240 0 0.0
.rodata 100064 100064 0 0.0
.text 757788 757788 0 0.0
bl706-wifi (read/write) 1245974 1245974 0 0.0
.bss 10565 10565 0 0.0
.data 3672 3672 0 0.0
.rodata 121044 121044 0 0.0
.text 988288 988288 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1163924 1163924 0 0.0
.bss 16316 16316 0 0.0
.data 5032 5032 0 0.0
.rodata 100748 100748 0 0.0
.text 959076 959076 0 0.0
bl702l+mfd (read/write) 1175832 1175832 0 0.0
.bss 16492 16492 0 0.0
.data 5008 5008 0 0.0
.rodata 99688 99688 0 0.0
.text 971396 971396 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 780668 780668 0 0.0
(read/write) 168864 168864 0 0.0
.bss 90884 90884 0 0.0
.data 3552 3552 0 0.0
.rodata 90324 90324 0 0.0
.text 690080 690080 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 799396 799396 0 0.0
(read/write) 179124 179124 0 0.0
.bss 101084 101084 0 0.0
.data 3580 3580 0 0.0
.rodata 84732 84732 0 0.0
.text 714396 714396 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 787924 787924 0 0.0
(read/write) 173580 173580 0 0.0
.bss 95540 95540 0 0.0
.data 3580 3580 0 0.0
.rodata 111444 111444 0 0.0
.text 676212 676212 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 738500 738500 0 0.0
(read/write) 167844 167844 0 0.0
.bss 89632 89632 0 0.0
.data 3540 3540 0 0.0
.rodata 86044 86044 0 0.0
.text 652192 652192 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 724156 724156 0 0.0
(read/write) 168048 168048 0 0.0
.bss 89848 89848 0 0.0
.data 3536 3536 0 0.0
.rodata 81892 81892 0 0.0
.text 642000 642000 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 580618 580618 0 0.0
(read/write) 207972 207972 0 0.0
.bss 201220 201220 0 0.0
.data 1628 1628 0 0.0
.rodata 86450 86450 0 0.0
.text 492044 492044 0 0.0
lock CC3235SF_LAUNCHXL (read only) 627458 627458 0 0.0
(read/write) 208312 208312 0 0.0
.bss 201672 201672 0 0.0
.data 1520 1520 0 0.0
.rodata 106954 106954 0 0.0
.text 518380 518380 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 564131 564131 0 0.0
.app_xip_area 453997 453997 0 0.0
.bss 64976 64976 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 548995 548995 0 0.0
.app_xip_area 434101 434101 0 0.0
.bss 69696 69696 0 0.0
.data 772 772 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 565803 565803 0 0.0
.app_xip_area 457165 457165 0 0.0
.bss 63520 63520 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 562531 562531 0 0.0
.app_xip_area 450621 450621 0 0.0
.bss 66680 66680 0 0.0
.data 804 804 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 928280 928272 -8 -0.0
.bss 197912 197912 0 0.0
.data 1372 1372 0 0.0
.text 728976 728968 -8 -0.0
BRD4187C (read/write) 1104652 1104652 0 0.0
.bss 195108 195108 0 0.0
.data 3384 3384 0 0.0
.text 906140 906140 0 0.0
lock-app BRD4161A+wf200 (read/write) 1121952 1121952 0 0.0
.bss 188216 188216 0 0.0
.data 2800 2800 0 0.0
.text 930916 930916 0 0.0
window-app BRD4187C (read/write) 1158576 1158576 0 0.0
.bss 168812 168812 0 0.0
.data 3332 3332 0 0.0
.text 986412 986412 0 0.0
esp32 all-clusters-app c3devkit (read only) 1201486 1201488 2 0.0
(read/write) 1747080 1747088 8 0.0
.dram0.bss 73576 73576 0 0.0
.dram0.data 13612 13612 0 0.0
.flash.rodata 250360 250368 8 0.0
.flash.text 1201486 1201488 2 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1243343 1243343 0 0.0
(read/write) 532012 532020 8 0.0
.dram0.bss 80432 80432 0 0.0
.dram0.data 35164 35164 0 0.0
.flash.rodata 280496 280504 8 0.0
.flash.text 1237179 1237179 0 0.0
.iram0.text 125403 125403 0 0.0
k32w contact k32w0+release (read only) 610256 610256 0 0.0
(read/write) 81332 81332 0 0.0
.bss 69112 69112 0 0.0
.data 2236 2236 0 0.0
.text 609720 609720 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 695900 695900 0 0.0
.bss 67760 67760 0 0.0
.data 2788 2788 0 0.0
.text 581880 581880 0 0.0
light k32w0+release (read only) 598664 598664 0 0.0
(read/write) 79340 79340 0 0.0
.bss 67168 67168 0 0.0
.data 2188 2188 0 0.0
.text 598128 598128 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 786840 786840 0 0.0
.bss 77436 77436 0 0.0
.data 2000 2000 0 0.0
.text 663952 663952 0 0.0
lock k32w0+release (read only) 581000 581000 0 0.0
(read/write) 78780 78780 0 0.0
.bss 66632 66632 0 0.0
.data 2164 2164 0 0.0
.text 580464 580464 0 0.0
linux air-purifier-app debug (read only) 2602189 2602189 0 0.0
(read/write) 128640 128640 0 0.0
.bss 46368 46368 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 74072 74072 0 0.0
.dynamic 608 608 0 0.0
.got 4560 4560 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 183784 183784 0 0.0
.text 2241157 2241157 0 0.0
all-clusters-app debug (read only) 5842801 5842817 16 0.0
(read/write) 477288 477288 0 0.0
.bss 133488 133488 0 0.0
.data 4464 4464 0 0.0
.data.rel.ro 331928 331928 0 0.0
.dynamic 624 624 0 0.0
.got 5376 5376 0 0.0
.init 27 27 0 0.0
.init_array 1360 1360 0 0.0
.rodata 346280 346280 0 0.0
.text 5065475 5065491 16 0.0
all-clusters-minimal-app debug (read only) 5154441 5154441 0 0.0
(read/write) 235768 235768 0 0.0
.bss 127504 127504 0 0.0
.data 4336 4336 0 0.0
.data.rel.ro 96840 96840 0 0.0
.dynamic 624 624 0 0.0
.got 5296 5296 0 0.0
.init 27 27 0 0.0
.init_array 1120 1120 0 0.0
.rodata 286938 286938 0 0.0
.text 4633539 4633539 0 0.0
bridge-app debug (read only) 4570233 4570233 0 0.0
(read/write) 216792 216792 0 0.0
.bss 117984 117984 0 0.0
.data 6144 6144 0 0.0
.data.rel.ro 85952 85952 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 227770 227770 0 0.0
.text 4122483 4122483 0 0.0
chip-tool debug (read only) 11961145 11961145 0 0.0
(read/write) 519824 519824 0 0.0
.bss 94296 94296 0 0.0
.data 5090 5090 0 0.0
.data.rel.ro 413200 413200 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 444889 444889 0 0.0
.text 10812691 10812691 0 0.0
chip-tool-ipv6only arm64 (read only) 11457784 11457784 0 0.0
(read/write) 590392 590392 0 0.0
.bss 103352 103352 0 0.0
.data 4472 4472 0 0.0
.data.rel.ro 452984 452984 0 0.0
.dynamic 512 512 0 0.0
.got 20312 20312 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 351684 351684 0 0.0
.text 10220460 10220460 0 0.0
lighting-app debug+rpc+ui (read only) 5491273 5491273 0 0.0
(read/write) 225608 225608 0 0.0
.bss 118936 118936 0 0.0
.data 4800 4800 0 0.0
.data.rel.ro 94368 94368 0 0.0
.dynamic 672 672 0 0.0
.got 5880 5880 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 352500 352500 0 0.0
.text 4892691 4892691 0 0.0
lock-app debug (read only) 4645305 4645305 0 0.0
(read/write) 204520 204520 0 0.0
.bss 113424 113424 0 0.0
.data 4128 4128 0 0.0
.data.rel.ro 80248 80248 0 0.0
.dynamic 624 624 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 848 848 0 0.0
.rodata 254906 254906 0 0.0
.text 4178819 4178819 0 0.0
ota-provider-app debug (read only) 4278913 4278913 0 0.0
(read/write) 192976 192976 0 0.0
.bss 113248 113248 0 0.0
.data 4288 4288 0 0.0
.data.rel.ro 69552 69552 0 0.0
.dynamic 624 624 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 206714 206714 0 0.0
.text 3879875 3879875 0 0.0
ota-requestor-app debug (read only) 4394345 4394345 0 0.0
(read/write) 197224 197224 0 0.0
.bss 114144 114144 0 0.0
.data 4688 4688 0 0.0
.data.rel.ro 72512 72512 0 0.0
.dynamic 624 624 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 212698 212698 0 0.0
.text 3985043 3985043 0 0.0
shell debug (read only) 2856817 2856833 16 0.0
(read/write) 155656 155656 0 0.0
.bss 62576 62576 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 85936 85936 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 186560 186560 0 0.0
.text 2497682 2497698 16 0.0
thermostat-no-ble arm64 (read only) 4465824 4465824 0 0.0
(read/write) 246152 246152 0 0.0
.bss 121768 121768 0 0.0
.data 3344 3344 0 0.0
.data.rel.ro 103512 103512 0 0.0
.dynamic 512 512 0 0.0
.got 12208 12208 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 158772 158772 0 0.0
.text 3962540 3962540 0 0.0
tv-app debug (read only) 5595337 5595337 0 0.0
(read/write) 350488 350488 0 0.0
.bss 243264 243264 0 0.0
.data 6496 6496 0 0.0
.data.rel.ro 93448 93448 0 0.0
.dynamic 624 624 0 0.0
.got 5512 5512 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 284058 284058 0 0.0
.text 5071043 5071043 0 0.0
tv-casting-app debug (read only) 9824625 9824625 0 0.0
(read/write) 339496 339496 0 0.0
.bss 156048 156048 0 0.0
.data 2912 2912 0 0.0
.data.rel.ro 173624 173624 0 0.0
.dynamic 624 624 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 380912 380912 0 0.0
.text 8979075 8979075 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2531440 2531440 0 0.0
.bss 220408 220408 0 0.0
.data 5208 5208 0 0.0
.text 1494124 1494124 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1094164 1094168 4 0.0
bss 129891 129891 0 0.0
rodata 111636 111640 4 0.0
text 804896 804900 4 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1214476 1214476 0 0.0
bss 122029 122029 0 0.0
rodata 141528 141528 0 0.0
text 800428 800428 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1044944 1044944 0 0.0
bss 129539 129539 0 0.0
rodata 99264 99264 0 0.0
text 768312 768312 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 835296 835296 0 0.0
(read/write) 1788404 1788404 0 0.0
.bss 195404 195404 0 0.0
.data 2640 2640 0 0.0
.text 1581972 1581972 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837648 837648 0 0.0
(read/write) 1713644 1713644 0 0.0
.bss 193076 193076 0 0.0
.data 2616 2616 0 0.0
.text 1509564 1509564 0 0.0
light cy8ckit_062s2_43012 (read only) 844352 844352 0 0.0
(read/write) 1634052 1634052 0 0.0
.bss 186556 186556 0 0.0
.data 2432 2432 0 0.0
.text 1436676 1436676 0 0.0
lock cy8ckit_062s2_43012 (read only) 817216 817216 0 0.0
(read/write) 1665740 1665740 0 0.0
.bss 213668 213668 0 0.0
.data 2456 2456 0 0.0
.text 1441228 1441228 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1124228 1124228 0 0.0
.bss 102384 102384 0 0.0
.data 808 808 0 0.0
.text 636608 636608 0 0.0
lock-app qpg6105+debug (read/write) 1088740 1088740 0 0.0
.bss 98600 98600 0 0.0
.data 852 852 0 0.0
.text 601116 601116 0 0.0
stm32 light STM32WB5MM-DK (read/write) 596621 596621 0 0.0
.bss 128288 128288 0 0.0
.data 660 660 0 0.0
.rodata 78764 78764 0 0.0
.text 379184 379184 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 825054 825054 0 0.0
bss 51036 51036 0 0.0
text 616918 616918 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1111924 1111936 12 0.0
bss 100844 100844 0 0.0
text 786328 786330 2 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1091088 1091088 0 0.0
bss 109936 109936 0 0.0
text 759362 759362 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 935296 935296 0 0.0
bss 92984 92984 0 0.0
text 649086 649086 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 826650 826650 0 0.0
bss 51088 51088 0 0.0
text 618580 618580 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 984628 984632 4 0.0
bss 79128 79128 0 0.0
text 699334 699336 2 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1096604 1096604 0 0.0
bss 100064 100064 0 0.0
text 772622 772622 0 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 957424 957424 0 0.0
bss 70588 70588 0 0.0
text 655022 655022 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 952944 952944 0 0.0
bss 92560 92560 0 0.0
text 666844 666844 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 884240 884240 0 0.0
bss 69152 69152 0 0.0
text 625454 625454 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 824860 824860 0 0.0
bss 57396 57396 0 0.0
text 592346 592346 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705780 705780 0 0.0
bss 73640 73640 0 0.0
text 462172 462172 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 828330 828330 0 0.0
bss 51216 51216 0 0.0
text 621280 621280 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 883665 883665 0 0.0
bss 60872 60872 0 0.0
text 635638 635638 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 850880 850880 0 0.0
bss 57684 57684 0 0.0
text 612346 612346 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 845440 845440 0 0.0
bss 58076 58076 0 0.0
text 606504 606504 0 0.0

@mergify mergify bot merged commit 8834be1 into project-chip:master Feb 2, 2024
@bzbarsky-apple bzbarsky-apple deleted the log-time-set-error branch February 2, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andy31415 andy31415 andy31415 approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees

No one assigned

Labels

app fast track review - pending

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bzbarsky-apple @andy31415