[Telink] Use Non-Concurrent commissioning for B9X & TLX SoCs#43175
Merged
mergify[bot] merged 29 commits intoproject-chip:masterfrom Mar 11, 2026
Merged
[Telink] Use Non-Concurrent commissioning for B9X & TLX SoCs#43175mergify[bot] merged 29 commits intoproject-chip:masterfrom
mergify[bot] merged 29 commits intoproject-chip:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the commissioning flow for Telink B9X and TLX SoCs to use the standard non-concurrent connection mechanism. This is a good simplification that removes platform-specific state management and a potential bug with singleton usage.
The changes look mostly correct, but I've found a couple of potential issues in BLEManagerImpl.cpp related to state checking that could cause incorrect behavior. Please see my detailed comments.
|
PR #43175: Size comparison from 90b16dd to 401ff2f Full report (22 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, psoc6, qpg, realtek, stm32)
|
|
PR #43175: Size comparison from 90b16dd to 38d8d98 Full report (49 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
s07641069
changed the title
|
PR #43175: Size comparison from 4500157 to 3355871 Full report (49 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #43175 +/- ##
=======================================
Coverage 54.04% 54.04%
=======================================
Files 1548 1548
Lines 106692 106692
Branches 13314 13314
=======================================
Hits 57667 57667
Misses 49025 49025 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
PR #43175: Size comparison from 4500157 to fe86c57 Full report (27 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32)
|
|
PR #43175: Size comparison from b2c44f5 to f37b159 Full report (48 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nxp, psoc6, qpg, realtek, stm32, telink)
|
…t during commissioning
|
PR #43175: Size comparison from a92c842 to 26e3a95 Full report (56 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #43175: Size comparison from 3fad7e8 to a68317f Full report (56 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #43175: Size comparison from 3fad7e8 to f2ed89c Full report (56 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
andy31415
approved these changes
Mar 11, 2026
Contributor
andy31415
left a comment
andy31415
left a comment
There was a problem hiding this comment.
Approving platform specific code implemented by platform maintainer.
andy31415
reviewed
Mar 11, 2026
arkq
approved these changes
Mar 11, 2026
|
PR #43175: Size comparison from 3fad7e8 to 1a5b8b0 Full report (11 builds for cc13x4_26x4, cc32xx, qpg, realtek, stm32)
|
Co-authored-by: Arkadiusz Bokowy <arkadiusz.bokowy@gmail.com>
|
PR #43175: Size comparison from ec85153 to 3711c85 Full report (56 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Alami-Amine
pushed a commit
to Alami-Amine/connectedhomeip
that referenced
this pull request
Mar 16, 2026
…-chip#43175) * [Telink] Use Non-Concurrent commsioning for B9X & TLX SoCs * [Telink] remove HandleThreadStateChange * [Telink] fix issue * Restyled by clang-format * [Telink] Fix stale DTS on rebuild * [Telink] Remove CommitConfiguration * [Telink] Rework ResetFailSafeTimer reset for unexpected BLE disconnect during commissioning * [Telink] Fix error * [Telink] Move otInstanceFinalize directly to AppTask * [Telink] Check return from InitCommonParts * [Telink] Fix temperature-measurement app build * [Telink] Move Thread networks prescaning into main init * [Telink] Switch to common Zephyr ThreadStackManagerImpl * [Telink] Fix Zephyr v3.3 builds * [Telink] Remove dependencies between Telink & Zephyr BLEManagerImpl * [Telink] Switch to common Zephyr BLEManagerImpl * Restyled by clang-format * [Telink] update stack values * [Telink] update stack values * [Telink] add error prints * Restyled by clang-format * Update src/platform/Zephyr/ThreadStackManagerImpl.cpp Co-authored-by: Arkadiusz Bokowy <arkadiusz.bokowy@gmail.com> --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Arkadiusz Bokowy <arkadiusz.bokowy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing