[CodeDriven] Convert Actions cluster to be code-driven#43471
Merged
mergify[bot] merged 11 commits intoproject-chip:masterfrom Mar 27, 2026
Merged
[CodeDriven] Convert Actions cluster to be code-driven#43471mergify[bot] merged 11 commits intoproject-chip:masterfrom
mergify[bot] merged 11 commits intoproject-chip:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request converts the Actions cluster to a code-driven model, introducing new ActionsCluster.h, ActionsCluster.cpp, and CodegenIntegration.cpp files, and refactoring existing actions-server.h and actions-server.cpp as a legacy facade. While this refactoring improves maintainability and testability, several security and stability issues were identified in the new ActionsCluster implementation. These include potential null pointer dereferences, a logic error in attribute reading, incompatible return types in InvokeCommand methods, and redundant checks in command handlers. Addressing these issues is crucial for the robustness and compliance of the cluster.
Elen777300
force-pushed
the
code_driven_actions_cluster
branch
2 times, most recently
from
cfd1b02 to
775c7bb
Compare
|
PR #43471: Size comparison from ae4c1e9 to ac7ff51 Full report (11 builds for cc13x4_26x4, cc32xx, qpg, realtek, stm32)
|
Elen777300
force-pushed
the
code_driven_actions_cluster
branch
from
ac7ff51 to
f42ba66
Compare
|
PR #43471: Size comparison from a92c842 to f42ba66 Full report (5 builds for cc32xx, realtek, stm32)
|
Elen777300
force-pushed
the
code_driven_actions_cluster
branch
2 times, most recently
from
1bd336a to
16a0a48
Compare
|
PR #43471: Size comparison from a92c842 to 16a0a48 Full report (24 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, nxp, psoc6, qpg, realtek, stm32)
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #43471 +/- ##
==========================================
+ Coverage 54.21% 54.26% +0.05%
==========================================
Files 1562 1563 +1
Lines 107371 107369 -2
Branches 13311 13316 +5
==========================================
+ Hits 58212 58266 +54
+ Misses 49159 49103 -56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
PR #43471: Size comparison from a92c842 to 7066dd2 Full report (24 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, nxp, psoc6, qpg, realtek, stm32)
|
|
PR #43471: Size comparison from a92c842 to c066589 Full report (34 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Elen777300
force-pushed
the
code_driven_actions_cluster
branch
from
c066589 to
5d09b69
Compare
|
PR #43471: Size comparison from a94849f to 5d09b69 Full report (10 builds for cc13x4_26x4, cc32xx, nrfconnect, realtek, stm32)
|
|
PR #43471: Size comparison from a94849f to 93ddef9 Full report (34 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Elen777300
force-pushed
the
code_driven_actions_cluster
branch
from
93ddef9 to
aaa2300
Compare
Elen777300
changed the title
|
PR #43471: Size comparison from a94849f to 2c7a59d Full report (34 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
andy31415
reviewed
Mar 9, 2026
andy31415
reviewed
Mar 9, 2026
andy31415
reviewed
Mar 9, 2026
andy31415
reviewed
Mar 9, 2026
tersal
reviewed
Mar 9, 2026
Elen777300
removed
controller
github
workflows
telink
tests
docker
examples chef
|
PR #43471: Size comparison from 1edbe71 to 2396b9c Full report (34 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Get rid of unnecessary checks Move private functions to be helper functions Cleanup code
- Rename OnStateChanged/OnActionFailed to GenerateEvent overloads taking
the event struct directly, reducing parameter count and matching the
underlying eventsGenerator API.
- Wrap ActionsCluster.cpp in namespace chip::app::Clusters to reduce
using-namespace boilerplate.
- Replace DispatchActionCommand template with inline decode/validate/
dispatch logic in InvokeCommand, as the template generalization added
complexity without benefit.
- Move BuildOptionalAttributes and BuildSetupURL (renamed ReadSetupURL)
to anonymous-namespace free functions in CodegenIntegration.cpp;
replace the fixed-size char[] buffer with std::string.
- Add singleton guard (sInstanceCount) to ActionsServer: the Actions
cluster is Node-scoped per the Matter spec and must live on a single
aggregator endpoint. Log an error on double-instantiation.
- Guard ActionListModified/EndpointListModified against calls for a
mismatched endpoint.
- Make Init/Shutdown idempotent via mRegistered flag to prevent spurious
error logs when the destructor calls Shutdown after an explicit call.
- Add README.md documenting the Node-scope constraint, per-endpoint
Elen777300
force-pushed
the
code_driven_actions_cluster
branch
from
2396b9c to
9892390
Compare
|
PR #43471: Size comparison from af89497 to 9892390 Full report (34 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
andy31415
approved these changes
Mar 27, 2026
andy31415
added
the
sdk-maintainer-approved
khodya
pushed a commit
to khodya/connectedhomeip
that referenced
this pull request
Apr 3, 2026
…43471) * Move Actions cluster to be code driven * Linter error fix * Fix includes and dependencies * Refactor ActionsCluster Get rid of unnecessary checks Move private functions to be helper functions Cleanup code * Read SetURL from ember * Add docs, fix test build * Restyled by clang-format * Actions cluster: address code review feedback - Rename OnStateChanged/OnActionFailed to GenerateEvent overloads taking the event struct directly, reducing parameter count and matching the underlying eventsGenerator API. - Wrap ActionsCluster.cpp in namespace chip::app::Clusters to reduce using-namespace boilerplate. - Replace DispatchActionCommand template with inline decode/validate/ dispatch logic in InvokeCommand, as the template generalization added complexity without benefit. - Move BuildOptionalAttributes and BuildSetupURL (renamed ReadSetupURL) to anonymous-namespace free functions in CodegenIntegration.cpp; replace the fixed-size char[] buffer with std::string. - Add singleton guard (sInstanceCount) to ActionsServer: the Actions cluster is Node-scoped per the Matter spec and must live on a single aggregator endpoint. Log an error on double-instantiation. - Guard ActionListModified/EndpointListModified against calls for a mismatched endpoint. - Make Init/Shutdown idempotent via mRegistered flag to prevent spurious error logs when the destructor calls Shutdown after an explicit call. - Add README.md documenting the Node-scope constraint, per-endpoint * Revisit the comments of the cluster, separate the backward compatability tests * Enable and fix backwards-compatibility tests * Move the backward compatability tests to the same definintion --------- Co-authored-by: Restyled.io <commits@restyled.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate
Actionscluster to be Code-DrivenRelated issues
43162
Testing
Tested using chip-all-clusters-app and matter-repl.
Added unit tests.
See: Pull Request Guidelines