[Realtek] Add error checking to app initialization and fix minor#71395
Merged
mergify[bot] merged 6 commits intoproject-chip:masterfrom Apr 9, 2026
Merged
[Realtek] Add error checking to app initialization and fix minor#71395mergify[bot] merged 6 commits intoproject-chip:masterfrom
mergify[bot] merged 6 commits intoproject-chip:masterfrom
Conversation
issues - Add error checking for Init(), Server::Init(), AddFabricDelegate() in AppTask.cpp - Add error handling for Binding::Manager operations in BindingHandler.cpp - Add error handling for RTKConfig read/write in BoltLockManager.cpp - Fix redundant chunkDuration >= 0 check in PushAVStreamTransportLogic.cpp - Add Python3 executable path to realtek.py build script
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds error checking and logging to initialization and configuration routines across multiple Realtek example applications. It also updates the build script and removes a redundant unsigned integer check. The review feedback suggests that the code should handle these errors by returning early or signaling failure, rather than just logging them, to prevent the applications from running in an unstable state.
|
PR #71395: Size comparison from 28d2aaf to 9308640 Full report (42 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #71395 +/- ##
=======================================
Coverage 54.26% 54.26%
=======================================
Files 1574 1574
Lines 108118 108118
Branches 13401 13401
=======================================
Hits 58669 58669
Misses 49449 49449 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
PR #71395: Size comparison from 28d2aaf to c06846c Full report (33 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #71395: Size comparison from 28d2aaf to e58c1c0 Full report (42 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
andy31415
reviewed
Apr 7, 2026
|
PR #71395: Size comparison from c6b4a3d to c86a38f Full report (42 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
andy31415
approved these changes
Apr 9, 2026
andy31415
reviewed
Apr 9, 2026
src/app/clusters/push-av-stream-transport-server/PushAVStreamTransportLogic.cpp
Show resolved
Hide resolved
andy31415
added
the
sdk-maintainer-approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issues
Testing