pdtm corrupts packages manager on tools removal#61
Merged
Conversation
xm1k3
added
the
Priority: High
If the tool exists, then it will be removed.
Mzack9999
requested changes
Jan 31, 2023
Member
There was a problem hiding this comment.
- Minor changes
- Evaluate if it's possible to write an integration test or add a step to GH action to ensure that no wrong binary gets deleted (packages manager corruption is a behavior that future potential changes should not re-introduce) - Probably this is blocked by #50
Contributor
Author
|
implemented also unit test related to crud operation in |
Mzack9999
requested changes
Feb 1, 2023
Mzack9999
requested changes
Feb 6, 2023
- more information related to github ratelimiting, AbuseRateLimitError to have the retry after info - added var CommonExtensions - GetExecutablePath refactoring, now returns also a bool to check if file exists
Mzack9999
requested changes
Feb 8, 2023
Mzack9999
approved these changes
Feb 13, 2023
ehsandeep
approved these changes
Feb 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.