Migrate @fluent/sequence to TypeScript#450
Merged
Merged
Conversation
Contributor
Author
|
With this PR, I've fleshed out the process of migrating our packages to TS. It's not a lot of work; I hope other packages will follow shortly. @Pike Would you like to take a look, please? |
Pike
reviewed
Jan 27, 2020
| export function mapBundleAsync( | ||
| bundles: AsyncIterable<FluentBundle>, | ||
| ids: Array<string> | ||
| ): Promise<Array<FluentBundle | null>>; |
Contributor
There was a problem hiding this comment.
Is there documentation on what these do, in combination with the impl below??
Contributor
Author
There was a problem hiding this comment.
They're function overloads: https://www.typescriptlang.org/docs/handbook/functions.html#overloads. They allow specifying extra typing constraints when the implementation is quite loose. E.g. "if you pass an array, expect an array as a result".
Pike
approved these changes
Jan 27, 2020
Pike
left a comment
Pike
left a comment
Contributor
There was a problem hiding this comment.
Aha, thing I'll soon forget (says that guy that can't claim TIL)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #376.