See prometheus/pushgateway#346 for a documentation update for the PGW about empty label values in the grouping key. (Note: It's really just documenting the current state of the PGW. No change of behavior of the PGW involved.)
The code in PushGateway.java currently accepts empty label values for the grouping key. However, it then attempts to push in an invalid way, see prometheus/pushgateway#344 for details (the issue demonstrates it with client_golang, but presumably client_java would show exactly the same behavior).
While the use case for empty label values in the grouping key is somewhat esoteric, a case can be made for it. Thus, we should probably support it in the way now documented. Alternative is to disallow it in PushGateway.java. Just the current state of pretending it works but then fail to push is clearly a bug.
See prometheus/pushgateway#346 for a documentation update for the PGW about empty label values in the grouping key. (Note: It's really just documenting the current state of the PGW. No change of behavior of the PGW involved.)
The code in
PushGateway.javacurrently accepts empty label values for the grouping key. However, it then attempts to push in an invalid way, see prometheus/pushgateway#344 for details (the issue demonstrates it with client_golang, but presumably client_java would show exactly the same behavior).While the use case for empty label values in the grouping key is somewhat esoteric, a case can be made for it. Thus, we should probably support it in the way now documented. Alternative is to disallow it in
PushGateway.java. Just the current state of pretending it works but then fail to push is clearly a bug.