-
Notifications
You must be signed in to change notification settings - Fork 830
feat: Add readTimeout and conenctionTimeout as configurable parameters #1658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
zeitlinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
| <version>${project.version}</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why a new dependency? have a look at
Line 21 in f613ab4
| class PushGatewayTest { |
...porter-pushgateway/src/main/java/io/prometheus/metrics/exporter/pushgateway/PushGateway.java
Outdated
Show resolved
Hide resolved
...porter-pushgateway/src/main/java/io/prometheus/metrics/exporter/pushgateway/PushGateway.java
Show resolved
Hide resolved
|
A pushed a change that reads the properties from a file to be in line with the other properties |
|
@hmhuan please fix the build - and let me know if you want to have this PR included in the upcoming release |
|
Hi @zeitlinger , Thank you for your support. I will fix the build and update on this weekend. |
Hey @zeitlinger, I have just remove the test dependency and remove redundant test. Please help me to review and include this PR in the upcoming release. Thank you very much |
Signed-off-by: huan.huynh <1612858@student.hcmus.edu.vn>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com> Signed-off-by: huan.huynh <1612858@student.hcmus.edu.vn>
Signed-off-by: huan.huynh <1612858@student.hcmus.edu.vn>
I got the issue like below so I would like to contribute to fix it by apply configurable for
connectionTimeoutandreadTimeout.