Change #!/usr/bin/python to #!/usr/bin/env python#945
Merged
csmarchbanks merged 3 commits intoprometheus:masterfrom Sep 11, 2023
Merged
Change #!/usr/bin/python to #!/usr/bin/env python#945csmarchbanks merged 3 commits intoprometheus:masterfrom
csmarchbanks merged 3 commits intoprometheus:masterfrom
Conversation
added 3 commits
June 25, 2023 21:26
Signed-off-by: Kishan Verma <kishanverma2312@gmail.com>
Signed-off-by: Kishan Verma <kishanverma2312@gmail.com>
Signed-off-by: Kishan Verma <kishanverma2312@gmail.com>
Member
|
Is this up to date and has actual test failure or does it need a rebase for tests to pass? |
csmarchbanks
approved these changes
Sep 11, 2023
Member
csmarchbanks
left a comment
csmarchbanks
left a comment
There was a problem hiding this comment.
Test failure is due to not being up to date with a fix to the tests. Merging anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was creating python version issues during installation. usr/bin/python points to a different version of python, than used in virtual env. Somehow, due to restrictions, can't change usr/bin/python. So changed to #!/usr/bin/env python. Already have a PR merged for this issue.