TSDB: Track count of unknown series referenced during WAL/WBL replay by pr00se · Pull Request #16166 · prometheus/prometheus

pr00se · 2025-03-05T00:47:40Z

In this PR:

track total number of series records referenced by WAL/WBL records with unknown series references
track tombstones that reference unknown series separately from samples
add counter metrics for unknown series references during WAL/WBL replay

bboreham

Seems plausible; can you update for the conflict and run some benchmarks please?

pr00se · 2025-03-17T06:14:40Z

@bboreham I ran the following on main and this branch:

go test -run='^$' -bench '^BenchmarkLoadWLs/.*,mmappedChunkT=0,oooSeriesPct=(0.000|0.500),oooSamplesPct=(0.000|0.500),oooCapMax=(0|32)' -timeout='3h' -count=100 -benchtime=1x -benchmem github.com/prometheus/prometheus/tsdb

results:

name                                                                                                                                                                             old time/op    new time/op    delta
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10       1.51s ±14%     1.50s ±12%    ~     (p=0.442 n=99+98)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=36,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10      1.50s ±16%     1.49s ±13%    ~     (p=0.635 n=100+98)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=72,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10      1.52s ±14%     1.50s ±13%    ~     (p=0.107 n=99+95)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=360,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10     1.54s ±11%     1.53s ±12%    ~     (p=0.389 n=99+99)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10       1.41s ±12%     1.41s ±13%    ~     (p=0.800 n=100+100)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=36,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10      1.40s ±14%     1.40s ±12%    ~     (p=0.557 n=100+98)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=72,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10      1.41s ±12%     1.40s ±11%    ~     (p=0.450 n=97+99)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=360,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10     1.44s ±12%     1.43s ±13%    ~     (p=0.235 n=99+99)
LoadWLs/batches=10,seriesPerBatch=10000,samplesPerSeries=50,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10       327ms ± 9%     328ms ± 8%    ~     (p=0.929 n=96+93)
LoadWLs/batches=10,seriesPerBatch=10000,samplesPerSeries=50,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10       365ms ±22%     352ms ±11%  -3.77%  (p=0.001 n=98+96)
LoadWLs/batches=10,seriesPerBatch=10000,samplesPerSeries=50,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10       302ms ± 9%     301ms ± 8%    ~     (p=0.730 n=92+96)
LoadWLs/batches=10,seriesPerBatch=10000,samplesPerSeries=50,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10       322ms ± 9%     324ms ±12%    ~     (p=0.502 n=94+98)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10       311ms ±18%     313ms ±14%    ~     (p=0.394 n=96+100)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10       312ms ±17%     318ms ±16%  +1.96%  (p=0.030 n=97+97)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=5,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10       319ms ±19%     320ms ±15%    ~     (p=0.580 n=96+97)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=24,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10      338ms ±16%     343ms ±15%    ~     (p=0.085 n=95+97)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10       292ms ±17%     292ms ±14%    ~     (p=0.842 n=98+94)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10       294ms ±20%     298ms ±16%    ~     (p=0.173 n=98+99)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=5,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10       295ms ±21%     298ms ±14%    ~     (p=0.275 n=100+96)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=24,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10      316ms ±19%     321ms ±20%    ~     (p=0.099 n=97+98)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.000-10      1.77s ±11%     1.76s ±10%    ~     (p=0.417 n=97+98)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.000-10      1.76s ±13%     1.76s ±11%    ~     (p=0.725 n=98+96)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=5,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.000-10      1.77s ±10%     1.76s ± 9%    ~     (p=0.461 n=93+98)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=24,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.000-10     1.81s ±12%     1.80s ±11%    ~     (p=0.353 n=99+98)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.100-10      1.63s ±12%     1.61s ± 9%    ~     (p=0.079 n=99+99)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.100-10      1.63s ±10%     1.62s ± 9%    ~     (p=0.284 n=100+97)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=5,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.100-10      1.62s ±10%     1.63s ±10%    ~     (p=0.772 n=99+97)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=24,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.100-10     1.65s ±11%     1.62s ±10%  -1.50%  (p=0.033 n=96+95)

name                                                                                                                                                                             old alloc/op   new alloc/op   delta
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10      70.5MB ± 0%    70.5MB ± 0%  +0.02%  (p=0.000 n=96+98)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=36,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10     72.4MB ± 0%    72.4MB ± 0%    ~     (p=0.424 n=96+94)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=72,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10     74.2MB ± 0%    74.2MB ± 0%  +0.02%  (p=0.003 n=94+93)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=360,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10    90.2MB ± 0%    90.2MB ± 0%  +0.02%  (p=0.001 n=98+94)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10      64.9MB ± 0%    64.9MB ± 0%  +0.03%  (p=0.000 n=93+95)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=36,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10     66.9MB ± 0%    66.9MB ± 0%  +0.04%  (p=0.000 n=94+93)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=72,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10     68.6MB ± 0%    68.6MB ± 0%  +0.03%  (p=0.000 n=92+92)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=360,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10    84.7MB ± 0%    84.7MB ± 0%  +0.03%  (p=0.000 n=94+94)
LoadWLs/batches=10,seriesPerBatch=10000,samplesPerSeries=50,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10       220MB ± 2%     220MB ± 2%    ~     (p=0.472 n=99+95)
LoadWLs/batches=10,seriesPerBatch=10000,samplesPerSeries=50,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10       263MB ± 4%     264MB ± 4%    ~     (p=0.210 n=98+100)
LoadWLs/batches=10,seriesPerBatch=10000,samplesPerSeries=50,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10       207MB ± 3%     208MB ± 3%  +0.63%  (p=0.000 n=98+99)
LoadWLs/batches=10,seriesPerBatch=10000,samplesPerSeries=50,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10       251MB ± 4%     253MB ± 3%  +0.81%  (p=0.000 n=98+100)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10      77.6MB ± 0%    77.6MB ± 0%    ~     (p=0.204 n=99+99)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10      80.4MB ± 0%    80.4MB ± 1%    ~     (p=0.902 n=97+99)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=5,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10      82.0MB ± 0%    82.0MB ± 1%    ~     (p=0.255 n=97+100)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=24,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10     91.3MB ± 1%    91.2MB ± 1%    ~     (p=0.517 n=99+100)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10      71.9MB ± 1%    72.1MB ± 1%  +0.26%  (p=0.000 n=95+94)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10      74.7MB ± 1%    75.0MB ± 1%  +0.39%  (p=0.000 n=97+99)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=5,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10      76.3MB ± 1%    76.6MB ± 1%  +0.30%  (p=0.000 n=96+97)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=24,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10     85.6MB ± 1%    85.8MB ± 1%  +0.25%  (p=0.000 n=98+98)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.000-10      571MB ± 0%     571MB ± 0%  -0.03%  (p=0.013 n=99+97)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.000-10      574MB ± 0%     574MB ± 0%    ~     (p=0.819 n=100+98)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=5,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.000-10      576MB ± 0%     576MB ± 0%    ~     (p=0.149 n=98+100)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=24,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.000-10     585MB ± 0%     585MB ± 0%  +0.03%  (p=0.011 n=99+95)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.100-10      517MB ± 0%     518MB ± 0%  +0.11%  (p=0.000 n=100+100)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.100-10      520MB ± 0%     521MB ± 0%  +0.11%  (p=0.000 n=98+99)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=5,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.100-10      521MB ± 0%     522MB ± 0%  +0.14%  (p=0.000 n=98+98)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=24,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.100-10     531MB ± 0%     531MB ± 0%  +0.12%  (p=0.000 n=98+99)

name                                                                                                                                                                             old allocs/op  new allocs/op  delta
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10        673k ± 0%      673k ± 0%  +0.02%  (p=0.000 n=98+98)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=36,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10       782k ± 0%      782k ± 0%  +0.01%  (p=0.016 n=99+99)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=72,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10       890k ± 0%      890k ± 0%  +0.01%  (p=0.000 n=96+94)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=360,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10     1.76M ± 0%     1.76M ± 0%  +0.00%  (p=0.000 n=100+99)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10        619k ± 0%      619k ± 0%  +0.02%  (p=0.000 n=94+95)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=36,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10       727k ± 0%      728k ± 0%  +0.02%  (p=0.000 n=95+93)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=72,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10       836k ± 0%      836k ± 0%  +0.01%  (p=0.000 n=92+92)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=360,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10     1.70M ± 0%     1.70M ± 0%  +0.01%  (p=0.000 n=93+96)
LoadWLs/batches=10,seriesPerBatch=10000,samplesPerSeries=50,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10       2.02M ± 0%     2.02M ± 0%    ~     (p=0.635 n=99+95)
LoadWLs/batches=10,seriesPerBatch=10000,samplesPerSeries=50,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10       2.62M ± 0%     2.62M ± 0%    ~     (p=0.587 n=90+98)
LoadWLs/batches=10,seriesPerBatch=10000,samplesPerSeries=50,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10       1.82M ± 0%     1.82M ± 0%  +0.01%  (p=0.041 n=100+97)
LoadWLs/batches=10,seriesPerBatch=10000,samplesPerSeries=50,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10       2.43M ± 0%     2.43M ± 0%    ~     (p=0.299 n=97+99)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10        610k ± 0%      610k ± 0%  +0.00%  (p=0.000 n=98+99)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10        670k ± 0%      670k ± 0%  +0.01%  (p=0.000 n=100+98)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=5,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10        760k ± 0%      761k ± 0%  +0.01%  (p=0.000 n=100+97)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=24,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10      1.33M ± 0%     1.33M ± 0%  +0.00%  (p=0.000 n=98+96)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10        555k ± 0%      555k ± 0%  +0.03%  (p=0.000 n=96+95)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10        615k ± 0%      615k ± 0%  +0.03%  (p=0.000 n=98+97)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=5,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10        705k ± 0%      705k ± 0%  +0.03%  (p=0.000 n=90+95)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=24,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10      1.28M ± 0%     1.28M ± 0%  +0.01%  (p=0.000 n=96+96)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.000-10      2.81M ± 0%     2.81M ± 0%    ~     (p=0.619 n=99+96)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.000-10      2.87M ± 0%     2.87M ± 0%  +0.01%  (p=0.016 n=97+95)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=5,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.000-10      2.96M ± 0%     2.96M ± 0%    ~     (p=0.322 n=99+96)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=24,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.000-10     3.53M ± 0%     3.53M ± 0%    ~     (p=0.077 n=97+94)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.100-10      2.54M ± 0%     2.54M ± 0%  +0.01%  (p=0.004 n=99+97)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.100-10      2.60M ± 0%     2.60M ± 0%  +0.02%  (p=0.000 n=99+95)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=5,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.100-10      2.69M ± 0%     2.69M ± 0%  +0.02%  (p=0.002 n=97+95)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=24,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.100-10     3.26M ± 0%     3.26M ± 0%  +0.01%  (p=0.000 n=94+95)

These show a very modest increase in memory usage, and a 1-4% difference in CPU time in a couple of the benchmarks. However, I don't thing the differences are significant. For additional reference, here is the same 100 runs against main compared by a subsequent 100 runs against main:

name                                                                                                                                                                             old time/op    new time/op    delta
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10       1.51s ±14%     1.48s ±12%  -1.41%  (p=0.047 n=99+99)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=36,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10      1.50s ±16%     1.51s ±14%    ~     (p=0.856 n=100+97)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=72,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10      1.52s ±14%     1.51s ±12%    ~     (p=0.613 n=99+99)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=360,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10     1.54s ±11%     1.54s ±14%    ~     (p=0.673 n=99+99)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10       1.41s ±12%     1.43s ±11%  +1.75%  (p=0.015 n=100+97)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=36,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10      1.40s ±14%     1.42s ±14%  +1.58%  (p=0.030 n=100+99)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=72,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10      1.41s ±12%     1.42s ±14%    ~     (p=0.117 n=97+100)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=360,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10     1.44s ±12%     1.45s ±13%    ~     (p=0.144 n=99+100)
LoadWLs/batches=10,seriesPerBatch=10000,samplesPerSeries=50,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10       327ms ± 9%     330ms ±11%    ~     (p=0.227 n=96+96)
LoadWLs/batches=10,seriesPerBatch=10000,samplesPerSeries=50,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10       365ms ±22%     352ms ±11%  -3.75%  (p=0.001 n=98+94)
LoadWLs/batches=10,seriesPerBatch=10000,samplesPerSeries=50,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10       302ms ± 9%     298ms ± 9%  -1.33%  (p=0.026 n=92+94)
LoadWLs/batches=10,seriesPerBatch=10000,samplesPerSeries=50,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10       322ms ± 9%     322ms ±10%    ~     (p=0.699 n=94+95)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10       311ms ±18%     313ms ±16%    ~     (p=0.542 n=96+98)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10       312ms ±17%     320ms ±19%  +2.53%  (p=0.018 n=97+97)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=5,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10       319ms ±19%     320ms ±16%    ~     (p=0.643 n=96+96)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=24,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10      338ms ±16%     348ms ±13%  +3.09%  (p=0.000 n=95+95)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10       292ms ±17%     295ms ±18%    ~     (p=0.370 n=98+99)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10       294ms ±20%     297ms ±20%    ~     (p=0.448 n=98+98)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=5,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10       295ms ±21%     300ms ±20%    ~     (p=0.240 n=100+95)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=24,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10      316ms ±19%     318ms ±16%    ~     (p=0.317 n=97+95)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.000-10      1.77s ±11%     1.76s ±12%    ~     (p=0.515 n=97+98)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.000-10      1.76s ±13%     1.79s ±12%  +1.71%  (p=0.006 n=98+100)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=5,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.000-10      1.77s ±10%     1.79s ±10%  +1.35%  (p=0.009 n=93+96)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=24,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.000-10     1.81s ±12%     1.80s ± 9%    ~     (p=0.439 n=99+99)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.100-10      1.63s ±12%     1.63s ±12%    ~     (p=0.737 n=99+98)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.100-10      1.63s ±10%     1.64s ±10%    ~     (p=0.351 n=100+96)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=5,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.100-10      1.62s ±10%     1.64s ±11%    ~     (p=0.242 n=99+98)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=24,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.100-10     1.65s ±11%     1.66s ±10%    ~     (p=0.187 n=96+99)

name                                                                                                                                                                             old alloc/op   new alloc/op   delta
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10      70.5MB ± 0%    70.5MB ± 0%    ~     (p=0.071 n=96+99)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=36,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10     72.4MB ± 0%    72.4MB ± 0%    ~     (p=0.410 n=96+95)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=72,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10     74.2MB ± 0%    74.2MB ± 0%  +0.01%  (p=0.027 n=94+94)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=360,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10    90.2MB ± 0%    90.2MB ± 0%    ~     (p=0.222 n=98+99)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10      64.9MB ± 0%    64.9MB ± 0%    ~     (p=0.121 n=93+93)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=36,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10     66.9MB ± 0%    66.9MB ± 0%    ~     (p=0.219 n=94+93)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=72,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10     68.6MB ± 0%    68.6MB ± 0%    ~     (p=0.888 n=92+88)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=360,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10    84.7MB ± 0%    84.7MB ± 0%    ~     (p=0.952 n=94+95)
LoadWLs/batches=10,seriesPerBatch=10000,samplesPerSeries=50,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10       220MB ± 2%     221MB ± 2%    ~     (p=0.609 n=99+97)
LoadWLs/batches=10,seriesPerBatch=10000,samplesPerSeries=50,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10       263MB ± 4%     264MB ± 4%    ~     (p=0.068 n=98+100)
LoadWLs/batches=10,seriesPerBatch=10000,samplesPerSeries=50,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10       207MB ± 3%     207MB ± 3%    ~     (p=0.649 n=98+97)
LoadWLs/batches=10,seriesPerBatch=10000,samplesPerSeries=50,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10       251MB ± 4%     250MB ± 5%    ~     (p=0.491 n=98+98)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10      77.6MB ± 0%    77.7MB ± 0%    ~     (p=0.377 n=99+100)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10      80.4MB ± 0%    80.5MB ± 0%    ~     (p=0.100 n=97+98)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=5,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10      82.0MB ± 0%    82.0MB ± 1%    ~     (p=0.386 n=97+98)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=24,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10     91.3MB ± 1%    91.2MB ± 0%    ~     (p=0.285 n=99+97)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10      71.9MB ± 1%    71.9MB ± 1%    ~     (p=0.978 n=95+98)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10      74.7MB ± 1%    74.7MB ± 1%    ~     (p=0.332 n=97+98)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=5,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10      76.3MB ± 1%    76.3MB ± 1%    ~     (p=0.077 n=96+95)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=24,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10     85.6MB ± 1%    85.6MB ± 1%    ~     (p=0.865 n=98+100)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.000-10      571MB ± 0%     571MB ± 0%    ~     (p=0.213 n=99+99)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.000-10      574MB ± 0%     574MB ± 0%    ~     (p=0.100 n=100+99)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=5,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.000-10      576MB ± 0%     576MB ± 0%    ~     (p=0.754 n=98+98)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=24,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.000-10     585MB ± 0%     585MB ± 0%    ~     (p=0.136 n=99+99)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.100-10      517MB ± 0%     517MB ± 0%    ~     (p=0.562 n=100+98)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.100-10      520MB ± 0%     520MB ± 0%    ~     (p=0.985 n=98+99)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=5,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.100-10      521MB ± 0%     522MB ± 0%  +0.04%  (p=0.006 n=98+97)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=24,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.100-10     531MB ± 0%     531MB ± 0%    ~     (p=0.917 n=98+98)

name                                                                                                                                                                             old allocs/op  new allocs/op  delta
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10        673k ± 0%      673k ± 0%    ~     (p=0.192 n=98+98)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=36,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10       782k ± 0%      782k ± 0%    ~     (p=0.287 n=99+91)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=72,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10       890k ± 0%      890k ± 0%    ~     (p=0.107 n=96+100)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=360,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10     1.76M ± 0%     1.76M ± 0%    ~     (p=0.107 n=100+99)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10        619k ± 0%      619k ± 0%    ~     (p=0.186 n=94+93)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=36,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10       727k ± 0%      727k ± 0%    ~     (p=0.324 n=95+93)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=72,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10       836k ± 0%      836k ± 0%    ~     (p=0.265 n=92+91)
LoadWLs/batches=10,seriesPerBatch=100,samplesPerSeries=7200,exemplarsPerSeries=360,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10     1.70M ± 0%     1.70M ± 0%    ~     (p=0.727 n=93+94)
LoadWLs/batches=10,seriesPerBatch=10000,samplesPerSeries=50,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10       2.02M ± 0%     2.02M ± 0%    ~     (p=0.538 n=99+96)
LoadWLs/batches=10,seriesPerBatch=10000,samplesPerSeries=50,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10       2.62M ± 0%     2.62M ± 0%    ~     (p=0.631 n=90+96)
LoadWLs/batches=10,seriesPerBatch=10000,samplesPerSeries=50,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10       1.82M ± 0%     1.82M ± 0%    ~     (p=0.687 n=100+96)
LoadWLs/batches=10,seriesPerBatch=10000,samplesPerSeries=50,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10       2.43M ± 0%     2.42M ± 0%    ~     (p=0.274 n=97+96)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10        610k ± 0%      610k ± 0%    ~     (p=0.302 n=98+100)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10        670k ± 0%      670k ± 0%    ~     (p=0.083 n=100+98)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=5,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10        760k ± 0%      760k ± 0%  +0.00%  (p=0.026 n=100+100)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=24,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.000-10      1.33M ± 0%     1.33M ± 0%    ~     (p=0.308 n=98+100)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10        555k ± 0%      555k ± 0%    ~     (p=0.995 n=96+98)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10        615k ± 0%      615k ± 0%    ~     (p=0.870 n=98+95)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=5,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10        705k ± 0%      705k ± 0%    ~     (p=0.986 n=90+95)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=24,mmappedChunkT=0,oooSeriesPct=0.000,oooSamplesPct=0.000,oooCapMax=0,missingSeriesPct=0.100-10      1.28M ± 0%     1.28M ± 0%    ~     (p=0.866 n=96+96)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.000-10      2.81M ± 0%     2.81M ± 0%    ~     (p=0.830 n=99+97)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.000-10      2.87M ± 0%     2.87M ± 0%  +0.01%  (p=0.015 n=97+98)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=5,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.000-10      2.96M ± 0%     2.96M ± 0%    ~     (p=0.862 n=99+98)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=24,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.000-10     3.53M ± 0%     3.53M ± 0%    ~     (p=0.857 n=97+95)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=0,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.100-10      2.54M ± 0%     2.54M ± 0%    ~     (p=0.557 n=99+97)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=2,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.100-10      2.60M ± 0%     2.60M ± 0%    ~     (p=0.710 n=99+93)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=5,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.100-10      2.69M ± 0%     2.69M ± 0%    ~     (p=0.105 n=97+94)
LoadWLs/batches=10,seriesPerBatch=1000,samplesPerSeries=480,exemplarsPerSeries=24,mmappedChunkT=0,oooSeriesPct=0.500,oooSamplesPct=0.500,oooCapMax=32,missingSeriesPct=0.100-10     3.26M ± 0%     3.26M ± 0%    ~     (p=0.982 n=94+97)

As you can see, there are similar CPU time differences running against the identical code. I'm not sure how to get the timing any more stable.

Signed-off-by: Patryk Prus <p@trykpr.us>

…p some OOO series as well Signed-off-by: Patryk Prus <p@trykpr.us>

TSDB: Track count of unknown series referenced during WAL/WBL replay

pr00se force-pushed the track-missing-series branch from 54ae623 to 18fea45 Compare March 5, 2025 00:51

pr00se marked this pull request as ready for review March 5, 2025 00:51

pr00se requested a review from jesusvazquez as a code owner March 5, 2025 00:51

pr00se force-pushed the track-missing-series branch from 18fea45 to 2a09367 Compare March 5, 2025 01:19

bboreham reviewed Mar 11, 2025

View reviewed changes

pr00se force-pushed the track-missing-series branch 4 times, most recently from 93b7337 to 0f0eb82 Compare March 13, 2025 23:42

bboreham approved these changes Mar 17, 2025

View reviewed changes

pr00se added 4 commits March 17, 2025 15:17

TSDB: Track count of unknown series referenced during WAL replay

85fa390

Signed-off-by: Patryk Prus <p@trykpr.us>

Add counters for unknown series references during WAL/WBL replay

401dbac

Signed-off-by: Patryk Prus <p@trykpr.us>

Add missing series refs to benchmark

2147538

Signed-off-by: Patryk Prus <p@trykpr.us>

Skip writing series records uniformly across the benchmark, so we ski…

86eeaf1

…p some OOO series as well Signed-off-by: Patryk Prus <p@trykpr.us>

pr00se force-pushed the track-missing-series branch from 28d97fd to 86eeaf1 Compare March 17, 2025 19:18

bboreham merged commit 37a41cc into prometheus:main Mar 17, 2025

pr00se deleted the track-missing-series branch March 17, 2025 21:26

This was referenced Mar 17, 2025

Add missing CHANGELOG entry #16225

Merged

Cherry-pick WAL/WBL replay improvements grafana/mimir-prometheus#849

Merged

pr00se mentioned this pull request Mar 24, 2025

Expose per-user metrics for unknown series references during WAL/WBL replay grafana/mimir#10981

Merged

zenador pushed a commit to zenador/prometheus that referenced this pull request Jun 2, 2025

Merge pull request prometheus#16166 from pr00se/track-missing-series

0ea11af

TSDB: Track count of unknown series referenced during WAL/WBL replay

SungJin1212 mentioned this pull request Aug 5, 2025

Add tsdb metrics to track unknown series references during wal/wbl re… cortexproject/cortex#6945

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TSDB: Track count of unknown series referenced during WAL/WBL replay#16166

TSDB: Track count of unknown series referenced during WAL/WBL replay#16166
bboreham merged 4 commits into
prometheus:mainfrom
pr00se:track-missing-series

pr00se commented Mar 5, 2025 •

edited

Loading

Uh oh!

bboreham left a comment

Uh oh!

pr00se commented Mar 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

pr00se commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bboreham left a comment

Choose a reason for hiding this comment

Uh oh!

pr00se commented Mar 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pr00se commented Mar 5, 2025 •

edited

Loading