Skip to content

26: Configure severity via config file#30

Closed
dorner wants to merge 2 commits intoprontolabs:masterfrom
dorner:severity-config
Closed

26: Configure severity via config file#30
dorner wants to merge 2 commits intoprontolabs:masterfrom
dorner:severity-config

Conversation

@dorner
Copy link
Copy Markdown

@dorner dorner commented Jun 30, 2017

See #26.

@mknapik
Copy link
Copy Markdown

mknapik commented Oct 5, 2017

@mmozuras Personally I find this feature quite useful. I can take care of testing if we're willing to merge it.

@mmozuras
Copy link
Copy Markdown
Member

mmozuras commented Oct 8, 2017

@mknapik sure, add tests and let's merge this one 🙂.

@adamolien
Copy link
Copy Markdown
Contributor

@mmozuras @mknapik Any updates on what happened to this PR? I recently came across the issue in my project. If it needs any help let me know and I can try to help out.

@mknapik
Copy link
Copy Markdown

mknapik commented Jun 27, 2019

@adamolien The structure of the gem changed but with a little bit of refactoring I managed to resolve conflicts.
If you would be willing to add some tests and test this version in your project. I could merge it to master.

@adamolien
Copy link
Copy Markdown
Contributor

@mknapik I added a few new tests. I am new to rspec though so please let me know if you want anything changed!

I am also a bit new to open source contributions, should I create a PR into this branch? Or what is the best way to get the code merged in?

@mknapik
Copy link
Copy Markdown

mknapik commented Jul 21, 2019

@adamolien Good question, I believe only members can push code to someone else PRs.
Feel free to create a new PR containing all commits from this PR with your code on top.

@doomspork
Copy link
Copy Markdown
Member

Feature added via #44

@doomspork doomspork closed this Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants