Enable suggestions when a line has multiple offenses#70
Merged
ashkulz merged 2 commits intoprontolabs:masterfrom Oct 8, 2021
Merged
Enable suggestions when a line has multiple offenses#70ashkulz merged 2 commits intoprontolabs:masterfrom
ashkulz merged 2 commits intoprontolabs:masterfrom
Conversation
Member
Contributor
Author
|
@ashkulz done |
ashkulz
approved these changes
Oct 8, 2021
Member
|
Thanks for the contribution, @letmein! |
Member
|
This has been pushed to RubyGems as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I found that suggestions are not being added when a line has more than one offense.
For example, we need to enforce double quotes:
This line will be counted twice here:
pronto-rubocop/lib/pronto/rubocop/offense_line.rb
Line 69 in 67d9cbf
And it will give a false positive in the following guard condition:
pronto-rubocop/lib/pronto/rubocop/offense_line.rb
Line 37 in 67d9cbf
I changed it to count only unique line numbers that contain offences, so the count of corrections matches
differing_lines_count.