Fix for RUBOCOP_CONFIG environment variable#72
Merged
ashkulz merged 1 commit intoprontolabs:masterfrom Dec 31, 2022
haseebab:rubocop_config_env
Merged
Fix for RUBOCOP_CONFIG environment variable#72ashkulz merged 1 commit intoprontolabs:masterfrom haseebab:rubocop_config_env
ashkulz merged 1 commit intoprontolabs:masterfrom
haseebab:rubocop_config_env
Conversation
|
@ashkulz , please merge this. It's been over a year since it was proposed, and it looks like a trivial fix. Or if there is any potential problem with it, could you say so? I just wasted a lot of time trusting the documentation. If you don't want to make this fix, then could you at least remove the misleading text from the readme? |
Member
|
Thanks for the contribution, @haseebab! |
Member
|
pronto-rubocop 0.11.4 has been released to RubyGems 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a proposal to fix #67
It looks like the use of
RUBOCOP_CONFIGwas removed in this commit: https://github.com/prontolabs/pronto-rubocop/pull/44/files#diff-f8a1b8209086b10d50565dc2776339d453c4bd8783d3c1dfb28907fcad85a125L37However, the README still mentions that
RUBOCOP_CONFIGis supported.