Re-respect rubocop files config#85
Merged
ashkulz merged 1 commit intoprontolabs:masterfrom Feb 27, 2023
Merged
Conversation
ashkulz
approved these changes
Feb 27, 2023
Member
|
Thanks for the contribution, @tejanium! I'll make a release at the end of the week 👍 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR #36 basically reverts changes from this PR #16 "Process files included in .rubocop.yml"
It happen because starting from https://github.com/prontolabs/pronto-rubocop/pull/36/files#diff-bd66c995e7650e0ca147e089eb3732f7a0b7bb0de38733f83e97485254285317R7 it passes down
ruby_patchesfrom Pronto's runner instead of the whole@patches, so it again ignores the files configured in.rubocop.yml. In our case, it ignores.jbuilderextensions