Fix Rubocop deprecated method warnings#91
Merged
ashkulz merged 3 commits intoprontolabs:masterfrom Aug 20, 2024
Merged
Conversation
Member
|
Closing and reopening so that CI is run. |
* `Cop.all` is deprecated. Use `Registry.all` instead. * `inspect_file` is deprecated. Use `investigate` instead.
44bdd26 to
15eabe3
Compare
Contributor
Author
|
@ashkulz I have made updates to check if new aliases are defined to support older Rubocop versions. Please take a look. |
Member
|
@ramil350 tests are still failing. |
Contributor
Author
|
@ashkulz Yeah, sorry. I can only run rspec locally for current version, which passed. Cannot check the whole workflow on my own. I see where the issue likely is, and pushed one more update. |
ashkulz
reviewed
Aug 19, 2024
ashkulz
approved these changes
Aug 19, 2024
Member
|
Thanks for the contribution, @ramil350! |
|
If possible, it would be great to have a release with this fixed to silence the warnings. Thanks! |
|
Yes, would be great to get a new version released with this improvement. @ashkulz 🙇 |
Member
|
Wow thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Rubocop deprecated method warnings:
Cop.allis deprecated. UseRegistry.allinstead.inspect_fileis deprecated. Useinvestigateinstead.