Merged
Conversation
Contributor
Author
bdon
reviewed
Nov 30, 2025
| assert.Nil(t, err) | ||
| } | ||
|
|
||
| func TestHttpBucketRequestWithQuery(t *testing.T) { |
Member
There was a problem hiding this comment.
@egorbn This test does not fail when the original code is left as-is.
Contributor
Author
There was a problem hiding this comment.
All the test are passing both in on github and when running go test ./pmtiles.
Am I missing something?
The publish step is failing because it's complaining about a password:
What do I need to do to fix that?
Member
There was a problem hiding this comment.
The publish step is failing because it's complaining about a password
Don't worry about this, it only matters when running on main
All the test are passing both in on github and when running
The test does not fail before the code change, so are you sure this is an effective test?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Currently,
NormalizeBucketKeydiscards the query string fromhttp://urls.This leads to errors when trying to
pmtiles show http://some.bucket.com/the_data.pmtiles?signature=blablabl:Changes
filetarget passed to theNewRangeReaderRelated issues
#255