Update rules_rust to 1.69.0, rust to 1.93.1.#496
Open
leonm1 wants to merge 9 commits intoproxy-wasm:mainfrom
Open
Update rules_rust to 1.69.0, rust to 1.93.1.#496leonm1 wants to merge 9 commits intoproxy-wasm:mainfrom
leonm1 wants to merge 9 commits intoproxy-wasm:mainfrom
Conversation
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
leonm1
requested review from
PiotrSikora,
martijneken and
mpwarres
as code owners
PiotrSikora
requested changes
Feb 26, 2026
PiotrSikora
reviewed
Feb 26, 2026
Member
PiotrSikora
left a comment
PiotrSikora
left a comment
There was a problem hiding this comment.
You need to regenerate crates (use bazelisk run //bazel/cargo/wasmsign:crates_vendor without arguments to avoid updating dependencies, since that's going to pollute PR).
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
PiotrSikora
reviewed
Feb 27, 2026
test/runtime_test.cc
Outdated
| EXPECT_TRUE(host->isErrorLogged(" - std::panicking::begin_panic")); | ||
| // Check for the function name 'one' in the backtrace, which may appear with or without | ||
| EXPECT_TRUE(host->isErrorLogged(" - std::panicking")); | ||
| // Check for the function name 'two' in the backtrace, which may appear with or without |
Member
There was a problem hiding this comment.
The code below still loook for function one not two as in the updated (outdated?) comment.
PiotrSikora
reviewed
Feb 27, 2026
PiotrSikora
changed the title
This reverts commit c19e738. Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
This was referenced Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.