Fix for #1728#1729
Conversation
|
I want to have a discussion on #1728 before we merge this. =) I'll make some comments inline on the diff anyway though. |
There was a problem hiding this comment.
I want to hide this from people. I think if we're doing this we should treat it as an implementation detail, e.g. this becomes _cookies.
|
@Lukasa if I take over the rest of this PR (to address our feedback) would we be comfortable getting it into 2.1? I feel like this addresses a real concern and I think you were in agreement with @gazpachoking at the end of #1728. Correct me if I'm wrong. For reference, I'll pull his commits onto a branch of mine, and just fix up the one minor thing and send a new PR and then close this one. Sound good? |
|
If you think you can get it done in a fairly swift manner, sure. =) |
- Make the PreparedRequest's cookie jar an implementation detail
Fix 1728 (Fixed up from #1729)
3 participants
This is how I think things should be fixed if we are okay with adding the cookiejar to
PreparedRequests. What do you guys think?