Keep Link header parameter values that contain '='#7520
Open
nyxst4ck wants to merge 1 commit into
Open
Conversation
parse_header_links split each parameter on '=' without a maxsplit, so a quoted
value containing '=' (allowed by RFC 8288) produced 3+ parts and raised
ValueError. The bare 'except ValueError: break' then silently dropped that
parameter and every parameter after it in the link.
Use split('=', 1) so the value keeps its '=' and later parameters survive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_header_linkssplits eachLinkheader parameter on=withkey, value = param.split("=")(nomaxsplit). RFC 8288 permits quotedparameter values that themselves contain
=(pagination/cursor tokens,base64 values, signed URLs, etc.). Such a value produces 3+ parts and raises
ValueError: too many values to unpack, which the bareexcept ValueError: breakswallows — silently dropping that parameter and every parameter afterit in the link.
Fix
param.split("=")→param.split("=", 1)inparse_header_links, so the valuekeeps its
=and following parameters are preserved.Tests
Added a
test_parse_header_linksparametrization with a value containing=(
title="a=b"followed byrel="next"). It fails onmain(bothtitleandthe trailing
relare dropped) and passes with the fix.tests/test_utils.py::test_parse_header_linksis green (6 passed);
ruff check/ruff formatclean.No existing issue tracked this; the bug is long-standing.