Fix README links in R implementation deploy tool#53
Merged
dmey merged 1 commit intopsychrometrics:masterfrom Jan 22, 2020
Merged
Fix README links in R implementation deploy tool#53dmey merged 1 commit intopsychrometrics:masterfrom
dmey merged 1 commit intopsychrometrics:masterfrom
Conversation
Contributor
Author
|
@dmey thanks! |
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
=======================================
Coverage 88.42% 88.42%
=======================================
Files 3 3
Lines 380 380
=======================================
Hits 336 336
Misses 44 44Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request view
The URL construction in updating links in
src/r/tools/deploy.Ris incorrect. The generated links were something likehttps://github.com/psychrometrics/psychrolibDEVELOP.md, which is invalid.Unfortunately, existing test platform cannot capture this type of error, except machines on CRAN. This PR fixes the issue by adding
/blob/master/between the GitHub repo link and target file name.