Skip to content

Speed up CI runtime for R package#58

Merged
dmey merged 18 commits intopsychrometrics:masterfrom
hongyuanjia:ci/RSPM
Apr 8, 2020
Merged

Speed up CI runtime for R package#58
dmey merged 18 commits intopsychrometrics:masterfrom
hongyuanjia:ci/RSPM

Conversation

@hongyuanjia
Copy link
Contributor

@hongyuanjia hongyuanjia commented Apr 8, 2020 •
edited
Loading

Pull request overview

  • Closes Reduce CI runtime for R #55. Speed up CI runtime for R package via:
    • Using RStudio Package Manager to install packages via pre-compiled binaries
    • Do not install packages in Suggests field of devtools
    • Remove code coverage checking
  • Related to Cap Sphinx version to avoid issue with newer version #56
    • Create NAMESPACE before calling devtools::document() Not necessary. devtools::document() will automatically create one. The root for the error lies in missing RcppExports.R
    • Manually call Rcpp::compileAttributes() to make sure RcppExports.R is created

Hongyuan Jia and others added 13 commits January 23, 2020 18:42
@hongyuanjia hongyuanjia mentioned this pull request Apr 8, 2020
Merged
@dmey dmey self-requested a review April 8, 2020 11:08
dmey
dmey reviewed Apr 8, 2020
View reviewed changes
.travis.yml Outdated
r: release
before_install:
- Rscript -e 'install.packages("devtools", dependencies = TRUE)'
- Rscript -e 'options(repos = c(CRAN = "https://demo.rstudiopm.com/all/__linux__/xenial/latest")); install.packages("devtools")'
Copy link
Contributor

@dmey dmey Apr 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this has improved the runtime -- the packages are still compiled from source.

Copy link
Contributor Author

@hongyuanjia hongyuanjia Apr 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Not sure why it does not work on Travis. Will keep the original. But remove dependencies = TRUE did reduce the package sizes to install. So I will keep it.

@hongyuanjia
Copy link
Contributor Author

hongyuanjia commented Apr 8, 2020

I would probably to keep this as is and eventually update this on CRAN at the new release.

I revise the Description because CRAN did not allow the Description to start with the package name Psychrolib. R CMD check will give a warning on CRAN machines.

@hongyuanjia
Copy link
Contributor Author

hongyuanjia commented Apr 8, 2020

The CI for R has been fixed. I will keep the current Description field as it is and update it on the next CRAN submission.

@hongyuanjia hongyuanjia mentioned this pull request Apr 8, 2020
Closed
@dmey dmey self-requested a review April 8, 2020 11:55
@dmey dmey merged commit 614a2e9 into psychrometrics:master Apr 8, 2020
@dmey dmey added this to the 2.5.0 milestone Apr 8, 2020
@hongyuanjia hongyuanjia deleted the ci/RSPM branch April 12, 2020 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmey dmey dmey approved these changes

Assignees

@hongyuanjia hongyuanjia

Labels

enhancement

Milestone

2.5.0

Development

Successfully merging this pull request may close these issues.

Reduce CI runtime for R

2 participants

@hongyuanjia @dmey