Switch runtime metrics to operation-weighted progress

[ptr727]

Summary

Reworks the develop-only runtime metrics (still 3.22, unreleased) from the v2 in-tool partial-credit model to a simpler operation-counting model. Each heavy full-file operation on a file counts the file's size as work to do when it starts (OpStarted) and as work done when it ends (OpCompleted), so progress.ratio = work.completed / work.total. The total grows as the non-deterministic per-file path is discovered — no per-file fraction weighting, and no parsing of tool progress output (which risked perturbing tool behavior).

Motivation: the metrics are a diagnostic for a small audience; the op-counting model is simpler, lower-risk (no -progress/--json/stdout-stream parsing in the processing path), and covers every heavy pass uniformly — including the ffprobe closed-caption scan, which has no incremental progress signal and so could not be instrumented under the v2 model.

Changes

• Metrics.cs: work.total/work.completed byte counters incremented at operation boundaries via an ambient thread-local file size; dropped the FileSink partial-credit machinery. bytes.total stays the static input-size reference.
• Bracketed the heavy full-file operations with OpStarted/OpCompleted: closed-caption scan, idet, ffmpeg re-encode (both overloads), HandBrake deinterlace, packet analysis, and VerifyMedia.
• Kept the tool progress-parsing capability unused-but-tested for the future media-tools library: FfMpeg/HandBrake.ParseProgressFraction, MediaTool.ExecuteStreamStdOut, and the Progress()/Json() builder methods, plus ToolProgressParsingTests. Only the Metrics wiring was removed.
• NativeAOT: the csproj sets <EventSourceSupport>true</EventSourceSupport> only when PublishAot=true, so an AOT build links the enabled EventPipe and exposes the diagnostics IPC server for dotnet-counters/dotnet-monitor. Default (non-AOT) builds are unchanged. (EventSourceSupport is the real switch; EventPipeSupport is a no-op.)

No version bump (develop-only feature, no released behavior). HISTORY 3.22 and the README Runtime Metrics section updated to describe op-counting.

Verification

• Build analyzer-clean, 0 warnings; CSharpier + dotnet format style --verify-no-changes --severity=info clean; 238 tests pass (op-counting fold math + the retained parser tests); markdownlint clean.
• Container e2e (container ffmpeg 8) — CoreCLR branch build: work.total grew as ops were discovered, progress.ratio = completed/total climbed. AOT binary: same, read live via the image counters wrapper.
• AOT e2e: the AOT binary runs the full pipeline in the develop image with container tools (Exit Code 0) and, with EventSourceSupport, creates the diagnostic socket so dotnet-counters attaches and reads the meter.

🤖 Generated with Claude Code

[Copilot]

Pull request overview

This PR refactors PlexCleaner’s develop-only runtime metrics to an operation-weighted model: each heavy full-file operation contributes the file’s size to work.total at start and to work.completed at completion, with progress.ratio derived from those gauges. It also adjusts tool wrappers and tests accordingly, and enables EventSource support for NativeAOT builds so metrics can be read via diagnostics tooling.

Changes:

• Replaced the prior per-file partial-credit progress model with operation-boundary OpStarted/OpCompleted accounting in Metrics.
• Wrapped heavy full-file operations (ffprobe scans, ffmpeg verify/idet/encode, HandBrake deinterlace, packet analysis) with OpStarted/OpCompleted and removed tool-output-driven progress reporting.
• Enabled EventSourceSupport for AOT publishes to ensure diagnostics IPC is available for dotnet-counters/dotnet-monitor.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
README.md	Updates the runtime-metrics documentation to describe operation-weighted progress and instrument set.
HISTORY.md	Updates 3.22 release notes to reflect the new operation-weighted progress model and instrument names.
PlexCleanerTests/MetricsTests.cs	Reworks unit tests to validate operation-weighted progress/ETA behavior and meter observability.
PlexCleaner/ProcessFile.cs	Removes the packet-level partial-credit reporting hook from analysis packet iteration.
PlexCleaner/ProcessDriver.cs	Switches file completion metrics call signature and ensures per-file thread-local size setup/teardown remains correct.
PlexCleaner/Process.cs	Removes now-unused duration seeding previously used for tool-progress-derived partial credit.
PlexCleaner/PlexCleaner.csproj	Enables EventSourceSupport only for PublishAot=true so metrics remain readable in AOT builds.
PlexCleaner/Metrics.cs	Implements operation-weighted work accounting via thread-local file size and new work.* gauges.
PlexCleaner/HandBrakeTool.cs	Removes progress-stream parsing and brackets the deinterlace operation with metrics work accounting.
PlexCleaner/FfProbeTool.cs	Brackets closed-caption scan and packet analysis with metrics work accounting.
PlexCleaner/FfMpegTool.cs	Brackets verify, idet, and encode operations with metrics work accounting; removes encode progress streaming.

[Copilot]

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.

[Copilot]

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

PlexCleaner/HandBrakeTool.cs:147

• Metrics.OpStarted() is called before Execute(...). If Execute returns false (cancellation or failure to start), work.total has already been incremented and is never rolled back, so progress.ratio/eta.seconds can remain skewed for the rest of the run. Consider only counting discovered work once the operation is confirmed to have started, or add a Metrics.OpAborted() (subtract current file size from work.total) and call it on the executed==false path.

            Metrics.OpStarted();
            bool executed = Execute(command, true, true, out BufferedCommandResult result);
            if (!executed)
            {
                return false;

[Copilot]

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.