Skip to content

Adopt shared markdownlint config, review-loop contract, and Copilot runbook#331

Merged
ptr727 merged 4 commits into
mainfrom
develop
Jun 8, 2026
Merged

Adopt shared markdownlint config, review-loop contract, and Copilot runbook#331
ptr727 merged 4 commits into
mainfrom
develop

Conversation

@ptr727

@ptr727 ptr727 commented Jun 8, 2026

Copy link
Copy Markdown
Owner

Promotes develop to main. Realignment with ProjectTemplate (#330): shared markdownlint config, PR Review Etiquette + Copilot review runbook, CRLF normalization. Also rolls up dependency bumps (#325-#327).

ptr727 and others added 4 commits June 5, 2026 06:37
Small PR to sync develop's dependency versions up to main (follow-up
after the dual-publish landing) and to exercise the new PR pipeline
end-to-end.

Touches `Directory.Packages.props` + `.config/dotnet-tools.json` (the
workflow's shared paths-filter anchor), so the smoke build should run.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Updated [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest)
from 18.4.0 to 18.6.0.

<details>
<summary>Release notes</summary>

_Sourced from [Microsoft.NET.Test.Sdk's
releases](https://github.com/microsoft/vstest/releases)._

## 18.6.0

## What's Changed
* Revert removal of Video Recorder by @​nohwnd in
microsoft/vstest#15336
* Speed up blame by filtering non-.NET processes from dump collection by
@​nohwnd in microsoft/vstest#15518
* Add README.md to NuGet packages by @​nohwnd in
microsoft/vstest#15550
* Report child process info on connection timeout by @​nohwnd in
microsoft/vstest#15603


### Changes to tests and infra
* Brand as 18.6 by @​nohwnd in
microsoft/vstest#15423
* Upgrading code coverage version to 18.5.1, by @​fhnaseer in
microsoft/vstest#15422
* Updating System.Collections.Immutable to 9.0.11 by @​MSLukeWest in
microsoft/vstest#15425
* Fix attachVS when used for debugging integration tests by @​nohwnd in
microsoft/vstest#15451
* Replace dotnet.config, with global.json by @​nohwnd in
microsoft/vstest#15449
* Document debugging integration tests with AttachVS by @​Copilot in
microsoft/vstest#15452
* Fix stack overflow tests by @​nohwnd in
microsoft/vstest#15461
* Make TestAssets.sln buildable locally by @​Youssef1313 in
microsoft/vstest#15466
* Try filtering out tests by @​nohwnd in
microsoft/vstest#15463
* Build just once when tfms run in parallel by @​nohwnd in
microsoft/vstest#15465
* Review simplify compatibility sources, deduplicate tests by @​nohwnd
in microsoft/vstest#15472
* Cleanup dead TRX code by @​Youssef1313 in
microsoft/vstest#15474
* Update .NET runtimes to 8.0.25, 9.0.14, and 10.0.4 by @​nohwnd in
microsoft/vstest#15481
* Compat matrix checker by @​nohwnd in
microsoft/vstest#15480
* Add trx analysis skill by @​nohwnd in
microsoft/vstest#15486
* Split integration tests to single tfm and multi tfm project by
@​nohwnd in microsoft/vstest#15484
* Update matrix by @​nohwnd in
microsoft/vstest#15477
* Break infinite restore loop in VS by @​nohwnd in
microsoft/vstest#15503
* Use global package cache for build, and local for running integration
tests by @​nohwnd in microsoft/vstest#15500
* Update contributing by @​nohwnd in
microsoft/vstest#15505
* Reduce test wall-clock time by increasing minThreads by @​drognanar in
microsoft/vstest#15502
* Indicator flakiness by @​nohwnd in
microsoft/vstest#15513
* Fix ci build by @​nohwnd in
microsoft/vstest#15515
* Fix thread safety issues by @​Evangelink in
microsoft/vstest#15512
* Optimize DotnetSDKSimulation_PostProcessing test (163s → 61s) by
@​nohwnd in microsoft/vstest#15516
* Build isolated test assets for single TFM instead of 7 by @​nohwnd in
microsoft/vstest#15517
* Remove unused dependencies from Library.IntegrationTests by @​nohwnd
in microsoft/vstest#15527
* Remove printing _attachments content to console by @​nohwnd in
microsoft/vstest#15520
* Add Linux/macOS test filtering guide to CONTRIBUTING.md by @​nohwnd in
microsoft/vstest#15521
* Change integration test parallelization from ClassLevel to MethodLevel
by @​nohwnd in microsoft/vstest#15526
* Unify target framework checks with IsNetFrameworkTarget/IsNetTarget by
@​nohwnd in microsoft/vstest#15523
* Add unattended work instructions to copilot-instructions.md by
@​nohwnd in microsoft/vstest#15531
* Reduce code style rule severity from warning to suggestion by @​nohwnd
in microsoft/vstest#15522
* Remove Debug/Release line number branching from tests by @​nohwnd in
microsoft/vstest#15519
* Revise unattended work instructions in copilot-instructions.md by
@​nohwnd in microsoft/vstest#15532
* Improve CompatibilityRowsBuilder error message with diagnostic details
by @​nohwnd in microsoft/vstest#15529
* docs: add git worktree and upstream sync workflow to
copilot-instructions.md by @​nohwnd in
microsoft/vstest#15538
* Add VSIX runner to smoke tests by @​nohwnd in
microsoft/vstest#15541
* Remove deprecated WebTest and TMI test methods by @​nohwnd in
microsoft/vstest#15525
* Fix compatibility test failures for legacy vstest.console and MSTest
adapter by @​nohwnd in microsoft/vstest#15534
* Convert TestPlatform.sln to slnx format by @​nohwnd in
microsoft/vstest#15551
* Convert test/TestAssets .sln files to .slnx format by @​nohwnd in
microsoft/vstest#15557
 ... (truncated)

## 18.5.1

## What's Changed
* Fix System.Collections.Immutable binding mismatch in Common.dll
(rel/18.5) by @​nohwnd in microsoft/vstest#15720
* Port verify-binding-redirects.ps1 to rel/18.5 by @​nohwnd in
microsoft/vstest#15719
* Bump to 18.5.1 by @​nohwnd in
microsoft/vstest#15721


**Full Changelog**:
microsoft/vstest@v18.5.0...v18.5.1

## 18.5.0

⚠️ Unlisted on Nuget, because of #​15718 

## What's Changed
* Add runtime configs by @​nohwnd in
microsoft/vstest#15377
* Add net8.0 target for TranslationLayer by @​nohwnd in
microsoft/vstest#15375
* Determine architecture of remote process on windows by @​nohwnd in
microsoft/vstest#15396
* Updating System.Collections.Immutable package reference to version
9.0.0 by @​MSLukeWest in microsoft/vstest#15392
* Dump via netcore tool on windows by @​nohwnd in
microsoft/vstest#15397
* Fix answer file splitting by @​nohwnd in
microsoft/vstest#15381
* Run tests against vsix runner by @​nohwnd in
microsoft/vstest#15419

**Full Changelog**:
microsoft/vstest@v18.4.0...v18.5.0

Commits viewable in [compare
view](microsoft/vstest@v18.4.0...v18.6.0).
</details>

Updated [Microsoft.SourceLink.GitHub](https://github.com/dotnet/dotnet)
from 10.0.201 to 10.0.300.

<details>
<summary>Release notes</summary>

_Sourced from [Microsoft.SourceLink.GitHub's
releases](https://github.com/dotnet/dotnet/releases)._

## 10.0.300

You can build .NET 10.0 from the repository by cloning the release tag
`v10.0.300` and following the build instructions in the [main
README.md](https://github.com/dotnet/dotnet/blob/v10.0.300/README.md#building).

Alternatively, you can build from the sources attached to this release
directly.
More information on this process can be found in the [dotnet/dotnet
repository](https://github.com/dotnet/dotnet/blob/v10.0.300/README.md#building-from-released-sources).

Attached are PGP signatures for the GitHub generated tarball and
zipball. You can find the public key at https://dot.net/release-key-2023

## 10.0.204

You can build .NET 10.0 from the repository by cloning the release tag
`v10.0.204` and following the build instructions in the [main
README.md](https://github.com/dotnet/dotnet/blob/v10.0.204/README.md#building).

Alternatively, you can build from the sources attached to this release
directly.
More information on this process can be found in the [dotnet/dotnet
repository](https://github.com/dotnet/dotnet/blob/v10.0.204/README.md#building-from-released-sources).

Attached are PGP signatures for the GitHub generated tarball and
zipball. You can find the public key at https://dot.net/release-key-2023

## 10.0.203

You can build .NET 10.0 from the repository by cloning the release tag
`v10.0.203` and following the build instructions in the [main
README.md](https://github.com/dotnet/dotnet/blob/v10.0.203/README.md#building).

Alternatively, you can build from the sources attached to this release
directly.
More information on this process can be found in the [dotnet/dotnet
repository](https://github.com/dotnet/dotnet/blob/v10.0.203/README.md#building-from-released-sources).

Attached are PGP signatures for the GitHub generated tarball and
zipball. You can find the public key at https://dot.net/release-key-2023

## 10.0.202

You can build .NET 10.0 from the repository by cloning the release tag
`v10.0.202` and following the build instructions in the [main
README.md](https://github.com/dotnet/dotnet/blob/v10.0.202/README.md#building).

Alternatively, you can build from the sources attached to this release
directly.
More information on this process can be found in the [dotnet/dotnet
repository](https://github.com/dotnet/dotnet/blob/v10.0.202/README.md#building-from-released-sources).

Attached are PGP signatures for the GitHub generated tarball and
zipball. You can find the public key at https://dot.net/release-key-2023

Commits viewable in [compare
view](dotnet/dotnet@v10.0.201...v10.0.300).
</details>

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Updated [csharpier](https://github.com/belav/csharpier) from 1.2.6 to
1.3.0.

<details>
<summary>Release notes</summary>

_Sourced from [csharpier's
releases](https://github.com/belav/csharpier/releases)._

## 1.3.0

# 1.3.0
## Breaking Changes
### Change xml formatting to return error when it runs into syntax error
so it is consistent with c#
[#​1854](belav/csharpier#1854)
Previously CSharpier treated an invalid xml file as a warning instead of
an error. This was inconsistent with how it treated c# files.
Invalid c# or xml files are not treated as errors.  
The `--compilation-errors-as-warnings` argument has been renamed to
`--syntax-errors-as-warnings` and can be used to return warnings instead
of errors when encountering invalid files.

## What's Changed

### Feature: Configurable whitespace handling for xml
[#​1790](belav/csharpier#1790)
CSharpier now supports two types of xml whitespace formatting strict or
ignore.
By default all xml except `xaml` or `axaml` is treated as strict
whitespace. See
[details](https://csharpier.com/docs/Configuration#xml-whitespace-sensitivity)

### Feature: Move closing bracket for xml elements to the same line.
[#​1598](belav/csharpier#1598)
With strict xml whitespace handling, csharpier now keeps the closing
bracket for an element on the same line instead of breaking it to a new
line.
```xml
<!-- input & expected output -->
<ElementWithAttribute Attribute="AttributeValue__________________"
  >TextValue</ElementWithAttribute>

<!-- 1.2.6 -->
<ElementWithAttribute Attribute="AttributeValue__________________"
  >TextValue</ElementWithAttribute
>
```
### Feature: Support for csharpier-ignore with XML formatter
[#​1788](belav/csharpier#1788)
CSharpier now supports `csharpier-ignore` in xml files. See
[details](https://csharpier.com/docs/Ignore#xml)

### Feature: Add MSBuild transitive and multi-target support
[#​1833](belav/csharpier#1833)
CSharpier.MSBuild can now work as a transitive dependency.

### Feature: allow checking formatting with cache
[#​1830](belav/csharpier#1830)
The `csharpier check` command now supports a `--use-cache` option.

### Feature: remove dependency on Microsoft.AspNetCore.App
[#​1508](belav/csharpier#1508)
Previously CSharpier required that Microsoft.AspNetCore.App be
installed. CSharpier has been modified to use an HttpListener when it is
run using `server` to remove the need for this dependency.

### Fix: csharpier-ignore comment removes linespaces before block
[#​1867](belav/csharpier#1867)
CSharpier was removing blank lines before csharpier-ignore comments in
some cases
```c#
// input and expected output
var x = 1;
    
// csharpier-ignore
var y=1;

/// 1.2.6
var x = 1;
// csharpier-ignore
var y=1;
 ... (truncated)

Commits viewable in [compare view](belav/csharpier@1.2.6...1.3.0).
</details>

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=csharpier&package-manager=nuget&previous-version=1.2.6&new-version=1.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Addresses #329 - realign with ptr727/ProjectTemplate.

- **Shared lint config:** carry `.markdownlint-cli2.jsonc` verbatim;
normalize blank lines / label a fence so docs pass clean.
- **Review-loop contract:** add the template's **PR Review Etiquette**
section to `AGENTS.md`.
- **Copilot runbook:** append the **GitHub Copilot Review Runbook** to
`.github/copilot-instructions.md` (owner/repo adapted to
`ptr727`/`Utilities`).
- **Line endings:** normalize both touched files to CRLF per
`.editorconfig` (they had pre-existing mixed CRLF/LF), and drop a
whitespace-only line in a code example.

Per your confirmation, this repo adopts the full review-loop docs
despite being NuGet-only. Its `.editorconfig` already governs line
endings, so no editorconfig rule change was needed.
Copilot AI review requested due to automatic review settings June 8, 2026 16:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR promotes develop to main while realigning the repository with the shared ProjectTemplate by adopting a common markdownlint configuration and documenting the expected PR review-loop contract (including a GitHub Copilot review runbook), alongside rolling up dependency/tooling version bumps.

Changes:

  • Updated centralized package versions (Directory.Packages.props) and .NET tool versions (.config/dotnet-tools.json).
  • Added a “PR Review Etiquette” contract to AGENTS.md and appended a “GitHub Copilot Review Runbook” to .github/copilot-instructions.md.
  • Introduced a shared .markdownlint-cli2.jsonc configuration for consistent markdown linting.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Directory.Packages.props Bumps common NuGet dependency versions used across the solution.
.config/dotnet-tools.json Updates pinned .NET tool versions used by repo automation/dev workflow.
AGENTS.md Documents the PR review-loop contract and triage expectations.
.github/copilot-instructions.md Adds an operational runbook for reliably triggering/polling Copilot reviews and resolving threads.
.markdownlint-cli2.jsonc Adds shared markdownlint-cli2 configuration for consistent doc linting.

Comment thread .markdownlint-cli2.jsonc
@ptr727 ptr727 merged commit 672f214 into main Jun 8, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants