Conversation
Updated [Serilog](https://github.com/serilog/serilog) from 4.3.1 to 4.4.0. <details> <summary>Release notes</summary> _Sourced from [Serilog's releases](https://github.com/serilog/serilog/releases)._ ## 4.4.0 ## What's Changed * Emit SelfLog warning when extra arguments are provided by @matantsach in serilog/serilog#2222 * dont WriteQuotedJsonString for null by @SimonCropp in serilog/serilog#2216 * Pin System.Security.Cryptography.Xml to 8.0.3 in tests by @ArieGato in serilog/serilog#2232 * Route optional interfaces through OptionalInterfaceForwardingSink for restricted sinks by @ArieGato in serilog/serilog#2234 * `SelfMetrics` by @nblumhardt in serilog/serilog#2237 ## New Contributors * @matantsach made their first contribution in serilog/serilog#2222 * @ArieGato made their first contribution in serilog/serilog#2232 **Full Changelog**: serilog/serilog@v4.3.1...v4.4.0 Commits viewable in [compare view](serilog/serilog@v4.3.1...v4.4.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…e-model) (#388) Part of the fleet release-model change: **a human PR merge never auto-cuts a release; only a bot (Dependabot/codegen) code-merge to `main` does, plus manual dispatch.** - **`push` trigger narrowed to `[main]`** — bot merges to `develop` no longer release; `develop` prereleases come via `workflow_dispatch`. - **Publish gated** to `github.actor == 'ptr727-codegen[bot]'` (the App merges every bot PR) / `dependabot[bot]`, so a human merge/promotion to `main` skips — the maintainer dispatches when release-ready. The `paths:` filter still means an Actions-only bump publishes nothing. - Empirically validated actor values on real runs (bot merges → App identity; human merges → `ptr727`). Header/comment updated to match. Takes effect on `main` once promoted. Companion to LanguageTags #255; template docs (WORKFLOW.md/AGENTS.md) + `PUBLISH_ON_MERGE` deletion follow. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #391 +/- ##
=======================================
Coverage 40.62% 40.62%
=======================================
Files 10 10
Lines 1024 1024
Branches 99 99
=======================================
Hits 416 416
Misses 580 580
Partials 28 28 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Promotion of develop -> main that advances the repository’s release automation to a gated model (auto-publish only for bot merges to main, otherwise publish via dispatch), and includes the NuGet dependency bump carried by this promotion.
Changes:
- Bump
Serilogfrom4.3.1to4.4.0via centralized package versions. - Gate
publish-release.ymlbehind a reusable “plan” workflow that decides whether publishing should occur, and restrict the push trigger tomain. - Minor workflow comment cleanup in
test-pull-request.yml.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Directory.Packages.props | Updates Serilog package version to 4.4.0. |
| .github/workflows/test-pull-request.yml | Removes an outdated/now-redundant CODECOV_TOKEN threading comment (secrets inheritance remains). |
| .github/workflows/publish-release.yml | Switches to a plan-driven publish gate; narrows push trigger to main; only validates/publishes when the plan says to publish. |
| .github/workflows/publish-plan-task.yml | Adds reusable workflow that computes publish/stable outputs from event/actor/ref to centralize release gating logic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotion of
develop->main.Carries:
publish-plan-task.yml(plan job) + gatedpublish-release.yml(a human merge never auto-publishes; only a bot code-merge to main, or a dispatch, does) + codecov-comment cleanup.Directory.Packages.propsnuget-deps bump.This promotion is also the live gate test. The diff touches
Directory.Packages.props(a release-affecting path), so on merge the now-gatedpublish-release.ymlwill trigger — and because the promotion is a human merge (github.actor = ptr727), theplanjob resolvespublish=falseand skips the publish. That proves a human merge/promotion does not auto-cut a release. (The next Dependabot/codegen merge tomain—actor = ptr727-codegen[bot]— will publish.)🤖 Generated with Claude Code