Skip to content

AGENTS: add author-identity commit rule#409

Merged
ptr727 merged 1 commit into
developfrom
fix/agents-author-identity
Jul 14, 2026
Merged

AGENTS: add author-identity commit rule#409
ptr727 merged 1 commit into
developfrom
fix/agents-author-identity

Conversation

@ptr727

@ptr727 ptr727 commented Jul 14, 2026

Copy link
Copy Markdown
Owner

Summary

A fleet governance audit found this repo's AGENTS.md defined the signing rule and the default-to-staging rule, but was missing the author-identity rule (which account/identity a commit must use). The canonical template AGENTS.md now defines this rule; this PR adds it here for fleet consistency.

Change

One bullet added to the Git and Commit Rules section, immediately after the existing "All commits must be cryptographically signed" bullet:

Commit under the committing account's own GitHub noreply identity - never a private, personal, or invented address...

It codifies that author/committer must be the GitHub noreply of the signing account (ptr727@users.noreply.github.com for this fleet), to verify user.email before committing, and why a wrong identity matters (GH007 email-privacy push protection, polluted history), while noting identity is distinct from signing.

Notes

  • Canonical wording inserted essentially verbatim, matching the existing bullet style.
  • ASCII-only, US English, - hyphens (no em-dashes).
  • File EOL (CRLF) preserved; zero mixed line endings.
  • Commit is SSH-signed.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

Fleet governance audit found this repo's AGENTS.md defined the
signing rule and the default-to-staging rule but was missing the
author-identity rule (which account/identity a commit must use).
Add the canonical bullet immediately after the signing rule so the
repo matches the template and the rest of the fleet.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 14, 2026 17:55
@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.89%. Comparing base (322fd8a) to head (1dab546).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #409   +/-   ##
========================================
  Coverage    66.89%   66.89%           
========================================
  Files           13       13           
  Lines         1160     1160           
  Branches       108      108           
========================================
  Hits           776      776           
  Misses         338      338           
  Partials        46       46           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repo’s agent governance documentation by adding an explicit commit author-identity rule to the Git and Commit Rules section, aligning AGENTS.md with the canonical fleet template and clarifying the expected author/committer identity for agent-authored commits.

Changes:

  • Add a new “GitHub noreply identity” rule requiring agent-authored commits to use the committing account’s GitHub noreply email (and to verify user.email before committing).
  • Document why incorrect author identity is operationally problematic (GH007 privacy protection, polluted history) and how it relates to - but is distinct from - signing.

@ptr727 ptr727 merged commit 06d0a0b into develop Jul 14, 2026
12 checks passed
@ptr727 ptr727 deleted the fix/agents-author-identity branch July 14, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants