AGENTS: add author-identity commit rule#409
Merged
Merged
Conversation
Fleet governance audit found this repo's AGENTS.md defined the signing rule and the default-to-staging rule but was missing the author-identity rule (which account/identity a commit must use). Add the canonical bullet immediately after the signing rule so the repo matches the template and the rest of the fleet. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #409 +/- ##
========================================
Coverage 66.89% 66.89%
========================================
Files 13 13
Lines 1160 1160
Branches 108 108
========================================
Hits 776 776
Misses 338 338
Partials 46 46 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repo’s agent governance documentation by adding an explicit commit author-identity rule to the Git and Commit Rules section, aligning AGENTS.md with the canonical fleet template and clarifying the expected author/committer identity for agent-authored commits.
Changes:
- Add a new “GitHub
noreplyidentity” rule requiring agent-authored commits to use the committing account’s GitHubnoreplyemail (and to verifyuser.emailbefore committing). - Document why incorrect author identity is operationally problematic (GH007 privacy protection, polluted history) and how it relates to - but is distinct from - signing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A fleet governance audit found this repo's
AGENTS.mddefined the signing rule and the default-to-staging rule, but was missing the author-identity rule (which account/identity a commit must use). The canonical templateAGENTS.mdnow defines this rule; this PR adds it here for fleet consistency.Change
One bullet added to the Git and Commit Rules section, immediately after the existing "All commits must be cryptographically signed" bullet:
It codifies that
author/committermust be the GitHubnoreplyof the signing account (ptr727@users.noreply.github.comfor this fleet), to verifyuser.emailbefore committing, and why a wrong identity matters (GH007 email-privacy push protection, polluted history), while noting identity is distinct from signing.Notes
-hyphens (no em-dashes).Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com