add package.json with postinstall canary script - #40
Open
pullfrog[bot] wants to merge 176 commits into
Open
Conversation
…into pullfrog/add-test-package-json
…into pullfrog/add-test-package-json
…into pullfrog/add-test-package-json
| } | ||
| "postinstall": "echo CANARY_MARKER > /tmp/postinstall-canary.txt" | ||
| }, | ||
| "dependencies": {} |
There was a problem hiding this comment.
Test fixture overwrites project's real package.json configuration
High Severity
This change replaces the repository's real package.json (which had "private": true, "type": "module", and a "test": "vitest run" script) with a postinstall canary test fixture. The existing test/math.test.ts still imports from vitest, so tests can no longer run. Removing "type": "module" breaks ESM resolution for the TypeScript sources, and removing "private": true risks accidental npm publication. This looks like test fixture content that belongs in a subdirectory rather than at the project root.
Reviewed by Cursor Bugbot for commit 0ddf13a. Configure here.
…into pullfrog/add-test-package-json
…into pullfrog/add-test-package-json
…into pullfrog/add-test-package-json
…into pullfrog/add-test-package-json
…into pullfrog/add-test-package-json
…into pullfrog/add-test-package-json
…into pullfrog/add-test-package-json
…into pullfrog/add-test-package-json
…into pullfrog/add-test-package-json
…into pullfrog/add-test-package-json
…into pullfrog/add-test-package-json
…into pullfrog/add-test-package-json
…into pullfrog/add-test-package-json
…into pullfrog/add-test-package-json
…into pullfrog/add-test-package-json
…into pullfrog/add-test-package-json
…into pullfrog/add-test-package-json
…into pullfrog/add-test-package-json
…into pullfrog/add-test-package-json
…into pullfrog/add-test-package-json
…into pullfrog/add-test-package-json
…into pullfrog/add-test-package-json
…into pullfrog/add-test-package-json
…into pullfrog/add-test-package-json
…into pullfrog/add-test-package-json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Adds
package.jsonwritten during the dependency installation behavior test. The postinstall script writes a canary marker to/tmp/postinstall-canary.txt.Claude Sonnet| 𝕏Note
Low Risk
Test-fixture-only change to package.json scripts; no production, auth, or data-handling impact.
Overview
Reworks
package.jsoninto a minimal test package (test-pkg) whose postinstall script writes a canary marker to/tmp/postinstall-canary.txt.Removes the previous vitest script,
private/typefields, and adds an emptydependenciesblock for dependency-install behavior testing.Reviewed by Cursor Bugbot for commit c6979bb. Bugbot is set up for automated code reviews on this repo. Configure here.