Skip to content

add package.json with postinstall canary script - #40

Open
pullfrog[bot] wants to merge 176 commits into
mainfrom
pullfrog/add-test-package-json
Open

add package.json with postinstall canary script#40
pullfrog[bot] wants to merge 176 commits into
mainfrom
pullfrog/add-test-package-json

Conversation

@pullfrog

@pullfrog pullfrog Bot commented May 27, 2026

Copy link
Copy Markdown

Adds package.json written during the dependency installation behavior test. The postinstall script writes a canary marker to /tmp/postinstall-canary.txt.

Pullfrog  | View workflow run | via Pullfrog | Using Claude Sonnet𝕏


Note

Low Risk
Test-fixture-only change to package.json scripts; no production, auth, or data-handling impact.

Overview
Reworks package.json into a minimal test package (test-pkg) whose postinstall script writes a canary marker to /tmp/postinstall-canary.txt.

Removes the previous vitest script, private/type fields, and adds an empty dependencies block for dependency-install behavior testing.

Reviewed by Cursor Bugbot for commit c6979bb. Bugbot is set up for automated code reviews on this repo. Configure here.

@pullfrog
pullfrog Bot requested a review from colinhacks May 27, 2026 23:51
Comment thread package.json
}
"postinstall": "echo CANARY_MARKER > /tmp/postinstall-canary.txt"
},
"dependencies": {}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test fixture overwrites project's real package.json configuration

High Severity

This change replaces the repository's real package.json (which had "private": true, "type": "module", and a "test": "vitest run" script) with a postinstall canary test fixture. The existing test/math.test.ts still imports from vitest, so tests can no longer run. Removing "type": "module" breaks ESM resolution for the TypeScript sources, and removing "private": true risks accidental npm publication. This looks like test fixture content that belongs in a subdirectory rather than at the project root.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 0ddf13a. Configure here.

pullfrog Bot added 21 commits June 1, 2026 18:03
pullfrog Bot added 30 commits August 4, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant