ci: Include testbench target in elaboration flows - #340
Merged
Conversation
colluca
force-pushed
the
extend-elab-tests
branch
from
July 2, 2026 14:03
f6a986c to
74e6b52
Compare
phsauter
marked this pull request as ready for review
July 2, 2026 14:45
phsauter
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ricted98 reported failing elaboration of
cc_cdc_2phase_clearable_tbwith VCS when testing v2-dev in Cheshire.Firstly, Cheshire doesn't depend on that file at all. This PR splits the existing Bender
testtarget into separatetestandtbtargets.testincludes reusable test sources that might be used by dependent repos.tbincludes common_cells-specific testbenches that are not expected to be reused by dependent repos.@ricted98 suggested that we further prefix it as
cc-tb, if we don't intend these files to be included by any dependencies. Bender now supports dependency-specific targets:-t my_pkg:my_targetactivatesmy_targetonly formy_pkg. Thus, I don't think prefixingtbis necessary; a repo should use<repo_package>:tbso no external testbench sources are included.Finally, the PR extends the elaboration tests to include all testbench, formal and synthesis wrapper sources. The ordering of the timescale and import statements in
cc_cdc_2phase_clearable_tbare exchanged so as to fix the same elaboration issue encountered by @ricted98.