Skip to content

Add "--metadata-signing-service" option to rpm#560

Merged
mdellweg merged 1 commit into
pulp:mainfrom
tjmullicani:main
Jun 2, 2023
Merged

Add "--metadata-signing-service" option to rpm#560
mdellweg merged 1 commit into
pulp:mainfrom
tjmullicani:main

Conversation

@tjmullicani

@tjmullicani tjmullicani commented Oct 7, 2022

Copy link
Copy Markdown
Contributor

Add "--metadata-signing-service" option to rpm repository

@tjmullicani

tjmullicani commented Oct 7, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Reference: https://github.com/pulp/pulp_rpm/blob/main/pulp_rpm/app/serializers/repository.py#L52

gerrod3
gerrod3 reviewed Oct 10, 2022
View reviewed changes

@gerrod3 gerrod3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! In order to pass our Ready-To-Ship CI check you need to attach an issue to the commit, e.g. fixes: #XXX

Comment thread pulpcore/cli/rpm/repository.py Outdated
@tjmullicani tjmullicani mentioned this pull request Oct 14, 2022
Closed
@mdellweg

mdellweg commented Oct 25, 2022

Copy link
Copy Markdown
Member

ping @tjmullicani any progress on this one?

@tjmullicani

tjmullicani commented Nov 22, 2022

Copy link
Copy Markdown
Contributor Author

Updated code

@tjmullicani tjmullicani reopened this Nov 22, 2022
@tjmullicani

tjmullicani commented Nov 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

fixes #605

mdellweg
mdellweg requested changes Nov 23, 2022
View reviewed changes

@mdellweg mdellweg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link to the older issue #605 .

Comment thread pulpcore/cli/rpm/repository.py Outdated
@mdellweg

mdellweg commented Nov 23, 2022

Copy link
Copy Markdown
Member

How do you think about adding a test for this?

@mdellweg

mdellweg commented Dec 7, 2022

Copy link
Copy Markdown
Member

How do you think about adding a test for this?

You probably need to setup a signing service here.
https://github.com/pulp/pulp-cli/blob/main/.ci/container_setup.d/10-install-signing-service.sh

mdellweg
mdellweg reviewed Mar 9, 2023
View reviewed changes

@mdellweg mdellweg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a signing service referenced in pulp ansible repository sign that can make good use of the resource_option, too.

Comment thread pulpcore/cli/rpm/repository.py Outdated
@tjmullicani tjmullicani force-pushed the main branch 3 times, most recently from 0fdeebd to 4d87df6 Compare March 9, 2023 19:22
@tjmullicani

tjmullicani commented Mar 9, 2023

Copy link
Copy Markdown
Contributor Author

requires #652

@tjmullicani tjmullicani force-pushed the main branch 2 times, most recently from 221d06a to 6e274c0 Compare March 9, 2023 20:34
mdellweg
mdellweg requested changes Mar 13, 2023
View reviewed changes

@mdellweg mdellweg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits.

Comment thread CHANGES/607.feature Outdated
@tjmullicani tjmullicani force-pushed the main branch 3 times, most recently from 22f303b to 3e9bd7d Compare March 13, 2023 14:48
@mdellweg

mdellweg commented Mar 13, 2023

Copy link
Copy Markdown
Member

isort is complaining here. have you run make black lint?

@tjmullicani @mdellweg
Add "--metadata-signing-service" option to rpm
b8d8264 
fixes pulp#605

Co-Authored-By: Matthias Dellweg <2500@gmx.de>
@tjmullicani

tjmullicani commented Jun 1, 2023

Copy link
Copy Markdown
Contributor Author

isort is complaining here. have you run make black lint?

fixed

@mdellweg mdellweg merged commit 154576d into pulp:main Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggainey ggainey ggainey left review comments

@gerrod3 gerrod3 gerrod3 left review comments

@mdellweg mdellweg mdellweg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tjmullicani @mdellweg @ggainey @gerrod3