Remove custom pytest hook and move pytest markers from pulp-smash

[hstct]

[noissue]

[mdellweg]

Although we could try to make this hook implementation optional, i think this is what we discussed, and we can always bring it back once we sorted out the pulp-smash story.

[hstct]

This hook will cause the CI pipeline to fail and don't run any functional tests if you don't install pulp-smash as a test requirement. From the matrix chat it seems that it is not really used anyway and the consensus was to just remove it.

It will run into this error here

With the removal the tests now run again: pulp/pulp_deb#851

[dkliban]

is this not used anywhere?

[mdellweg]

is this not used anywhere?

@dkliban not in any CI at least (It contradicts the parallel execution of tests).
If you are a regular user of this feature, we need to find a way to make the implementation of this hook dependent of the existence of its declaration (currently in pulp-smash).

[lubosmj]

Can we also move this from pulp_smash: https://github.com/pulp/pulp-smash/blob/2ded6671e0f32c51e70681467199e8a195f7f5fe/pulp_smash/pulp3/pytest_plugin/__init__.py#L76? I think @hstct mentioned that without that, he sees some warnings in the pulp_deb's CI.

[mdellweg]

Can we also move this from pulp_smash: https://github.com/pulp/pulp-smash/blob/2ded6671e0f32c51e70681467199e8a195f7f5fe/pulp_smash/pulp3/pytest_plugin/__init__.py#L76? I think @hstct mentioned that without that, he sees some warnings in the pulp_deb's CI.

Only the second half of it, but yes, we should.

[hstct]

Can we also move this from pulp_smash: https://github.com/pulp/pulp-smash/blob/2ded6671e0f32c51e70681467199e8a195f7f5fe/pulp_smash/pulp3/pytest_plugin/__init__.py#L76? I think @hstct mentioned that without that, he sees some warnings in the pulp_deb's CI.

Only the second half of it, but yes, we should.

I can include this to this PR or open a new one whatever is preferred 🙂

[lubosmj]

Include it in this one, please.

[patchback]

Backport to 3.29: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.29/ed3314079e7e199ae99db4e1f05ed1668e4664f7/pr-4177

Backported as #4239

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[patchback]

Backport to 3.28: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.28/ed3314079e7e199ae99db4e1f05ed1668e4664f7/pr-4177

Backported as #4246

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.