Add support for transfer_config in S3 domain serializer#5252
Merged
Conversation
gerrod3
force-pushed
the
storage-create
branch
2 times, most recently
from
4db1373 to
d96e2f4
Compare
mdellweg
reviewed
Apr 15, 2024
| from .fields import EncryptedJSONField | ||
|
|
||
| # Global used to store instantiated storage classes to speed up lookups across domains | ||
| storages = {} |
Member
There was a problem hiding this comment.
This is a per worker in memory cache, right? So a bit like lru_cache just with the last update check.
Contributor
Author
There was a problem hiding this comment.
Yep, that is correct. Since get_storage is called everytime an artifact is saved/read, it makes sense to have a cache to speed up the access.
mdellweg
approved these changes
Apr 15, 2024
ggainey
approved these changes
Apr 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change will also allow me to add GCP support for domains since the
credentialssetting requires a Google object.