Fix RepositoryVersion.content query failing when >65K units#6784
Merged
Conversation
8d3e504 to
231fad6
Compare
jobselko
reviewed
Jul 14, 2025
|
|
||
| return content_qs.filter(pk__in=self._get_content_ids()) | ||
| content_ids = self._get_content_ids() | ||
| if isinstance(content_ids, list) and len(content_ids) >= 65535: |
Member
There was a problem hiding this comment.
What about making a constant from this number, e.g. POSTGRESQL_MAX_PARAMS?
jobselko
approved these changes
Jul 15, 2025
dkliban
approved these changes
Jul 15, 2025
dkliban
left a comment
Member
There was a problem hiding this comment.
i tested this patch on our production instance. i was able to publish a repository with 267K units. It took a little less than 5 minutes!
Backport to 3.83: 💚 backport PR created✅ Backport PR branch: Backported as #6786 🤖 @patchback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #6772
This is the orm magic breaks down to this sql: