[PR #6940/fc99a60a backport][3.89] Fix parameters passed for GCS URL generation#6956
Merged
ggainey merged 1 commit intoSep 18, 2025
Conversation
When GCP support was originally added, the parameters were `response_disposition` and `content_type`. When it was refactored in #4251, the headers were GCS were mistakenly changed and expanded. These parameters get used by `generate_signed_url` method defined in https://github.com/googleapis/python-storage/blob/a8109e0/google/cloud/storage/blob.py#L463, through https://github.com/jschneier/django-storages/blob/758ad6f/storages/backends/gcloud.py#L350 This PR ensures only the supported parameters are passed to that function call. closes #6917 Signed-off-by: Balasankar 'Balu' C <balu@dravidam.net> (cherry picked from commit fc99a60)
ggainey
approved these changes
Sep 18, 2025
ggainey
deleted the
patchback/backports/3.89/fc99a60a59398909ebab38ffe9e3f2196f9c9855/pr-6940
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #6940 as merged into main (fc99a60).
When GCP support was originally added in #3481, the parameters were
response_dispositionandcontent_type. When it was refactored in #4251, the headers for GCS were mistakenly changed and expanded.These parameters get used by
generate_signed_urlmethod defined in https://github.com/googleapis/python-storage/blob/a8109e0/google/cloud/storage/blob.py#L463, throughhttps://github.com/jschneier/django-storages/blob/758ad6f/storages/backends/gcloud.py#L350
This PR ensures only the supported parameters are passed to that function call.
closes #6917