[PULP-578] Optimize filtering of repo versions by content

[jobselko]

closes #7799

📜 Checklist

• Commits are cleanly separated with meaningful messages (simple features and bug fixes should be squashed to one commit)
• A changelog entry or entries has been added for any significant changes
• Follows the Pulp policy on AI Usage
• (For new features) - User documentation and test coverage has been added

See: Pull Request Walkthrough

[mdellweg]

Nice work.

[mdellweg]

What is this branch for? (According to the docstring, content is always a queryset.)

[jobselko]

DistributionWithContentFilter.filter sends a list (versions = RepositoryVersion.objects.with_content([content.pk]).values_list("pk", flat=True)), so the docstring was already outdated. Updated now.

[mdellweg]

values_list should still return a (lazily evaluated) queryset:

https://docs.djangoproject.com/en/6.0/ref/models/querysets/#values-list

[jobselko]

values_list is not what is passed in. [content.pk] is the argument to with_content(), and this is a plain list, not a queryset

[jobselko]

So I changed list(content) to just content as __overlap accepts any iterable.

EDIT: overlap only works on lists, list() is still needed

[mdellweg]

I may be missing something. But the queryset from line 902 works with overlap perfectly, right?

[jobselko]

Yeah, overlap is happy with both querysets and lists (so not only with lists, I was wrong).

[dralley]

So does that mean the branch is unnecessary?

[jobselko]

Measured benefit by repeatedly adding/removing the same content unit into a repo (creating 2 RepositoryVersion and 1 RepositoryContent per cycle):

Without patch:
Response time grows with the number of cycles (e.g. ~0.5s at 100, ~2-3s at 700)

With patch:
Response time stays constant at ~0.45s regardless of the number of cycles