-
Notifications
You must be signed in to change notification settings - Fork 17
Closed
Labels
area/codegenAffects quality or correctness of generated codeAffects quality or correctness of generated codekind/enhancementImprovements or new featuresImprovements or new featureslanguage/javascriptresolution/fixedThis issue was fixedThis issue was fixed
Description
Expected behavior
Typedefs for k8s should not also accept ... | undefined
Current behavior
Currently the generated code produces the following incorrect typedefs:
public readonly apiVersion!: pulumi.Output<"foo/v1" | undefined>;
public readonly kind!: pulumi.Output<"Foo" | undefined>;
public readonly metadata!: pulumi.Output<ObjectMeta | undefined>;
public readonly status!: pulumi.Output<outputs.foo.bar | undefined>;
These need to be corrected to:
public readonly apiVersion!: pulumi.Output<"foo/v1">;
public readonly kind!: pulumi.Output<"Foo">;
public readonly metadata!: pulumi.Output<ObjectMeta>;
public readonly status!: pulumi.Output<outputs.foo.bar>;
See example of a k8s Deployment in pulumi-kubernetes that follows suit with the proposed corrections.
Related:
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area/codegenAffects quality or correctness of generated codeAffects quality or correctness of generated codekind/enhancementImprovements or new featuresImprovements or new featureslanguage/javascriptresolution/fixedThis issue was fixedThis issue was fixed