Fix: excluding files from unneededGoFiles was not working#120
Merged
mjeffryes merged 6 commits intopulumi:masterfrom Dec 12, 2023
shamil:uneeded_go_files_fix
Merged
Fix: excluding files from unneededGoFiles was not working#120mjeffryes merged 6 commits intopulumi:masterfrom shamil:uneeded_go_files_fix
mjeffryes merged 6 commits intopulumi:masterfrom
shamil:uneeded_go_files_fix
Conversation
Contributor
Author
|
Seems similar to #77 with a bit different approach to preserve current directory structure |
Contributor
Author
|
@mjeffryes can you also look at this PR? |
Contributor
Author
|
@mjeffryes I added the requested test in fcd5520 One caveat, since in this project the Let me know if anything else needed. |
mjeffryes
reviewed
Dec 12, 2023
Contributor
mjeffryes
left a comment
mjeffryes
left a comment
There was a problem hiding this comment.
Thanks that looks great!
mjeffryes
approved these changes
Dec 12, 2023
Contributor
Author
|
@mjeffryes thanks a lot for quick review. When should we expect a new release? |
Contributor
|
I've just kicked off a release build here: https://github.com/pulumi/crd2pulumi/actions/runs/7186377517 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
files in
unneededGoFileswere not excluded.Bug Description
unneededGoFilesstring set contain files which are relative to the import path (kubernetes/*), while the paths of generated files are relative topkg.Name(crds/*). This PR makes sure to use a proper path when comparing files inunneededGoFiles.