Skip to content

Pin the k8s version in the generated resources for node #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjeffryes merged 4 commits into from
Dec 18, 2023
Merged

Pin the k8s version in the generated resources for node #121

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7c55d28
Pin the k8s version in the generated resources for node
mjeffryes Dec 13, 2023
617f58b
Changelog
mjeffryes Dec 13, 2023
8ae8419
feedback
mjeffryes Dec 18, 2023
81082b6
feedback
mjeffryes Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feedback
  • Loading branch information
@mjeffryes
mjeffryes committed Dec 18, 2023
commit 8ae84199bfb45d4135308a2e60e00bc72480e4af
16 changes: 14 additions & 2 deletions tests/crds_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
package tests

import (
"bytes"
"fmt"
"io/fs"
"os"
Expand Down Expand Up @@ -124,8 +125,8 @@ func TestKubernetesVersionNodeJs(t *testing.T) {
// enter and build the generated package
withDir(t, path, func() {

require.NoError(t, exec.Command("npm", "i").Run())
require.NoError(t, exec.Command("npm", "run", "build").Run())
runRequireNoError(t, exec.Command("npm", "install"))
runRequireNoError(t, exec.Command("npm", "run", "build"))

// extract the version returned by a resource
appendFile(t, "bin/index.js", "\nconsole.log((new k8sversion.test.TestResource('test')).__version)")
Expand Down Expand Up @@ -157,3 +158,14 @@ func appendFile(t *testing.T, filename, content string) {

_, err = f.WriteString(content)
}

func runRequireNoError(t *testing.T, cmd *exec.Cmd) {
Copy link
Contributor

@rquitales rquitales Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: you could also use https://pkg.go.dev/os/exec#Cmd.CombinedOutput to do this.

Copy link
Contributor Author

@mjeffryes mjeffryes Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks, I was looking for that, but didn't see it!

buf := new(bytes.Buffer)
cmd.Stdout = buf
cmd.Stderr = buf
err := cmd.Run()
if err != nil {
t.Log(buf)
}
require.NoError(t, err)
}