Skip to content

Add generating CRD from URL #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lblackstone merged 3 commits into from
Jan 4, 2022
Merged

Add generating CRD from URL #62

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a43f90
Add support for generating via URL
akrantz01 Dec 23, 2021
9280ad9
Add test case
akrantz01 Dec 23, 2021
605bb52
Add URL example
akrantz01 Dec 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add URL example
  • Loading branch information
@akrantz01
akrantz01 committed Dec 23, 2021
commit 605bb526e93e8f9546d860426a48379291178987
3 changes: 2 additions & 1 deletion cmd/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ CustomResourceDefinition YAML schema.`
const example = `crd2pulumi --nodejs crontabs.yaml
crd2pulumi -dgnp crd-certificates.yaml crd-issuers.yaml crd-challenges.yaml
crd2pulumi --pythonPath=crds/python/istio --nodejsPath=crds/nodejs/istio crd-all.gen.yaml crd-mixer.yaml crd-operator.yaml
crd2pulumi --pythonPath=crds/python/gke https://raw.githubusercontent.com/GoogleCloudPlatform/gke-managed-certs/master/deploy/managedcertificates-crd.yaml

Notice that by just setting a language-specific output path (--pythonPath, --nodejsPath, etc) the code will
still get generated, so setting -p, -n, etc becomes unnecessary.
Expand Down Expand Up @@ -117,7 +118,7 @@ func NewLanguageSettings(flags *pflag.FlagSet) (gen.LanguageSettings, []string)
if golang {
notices = append(notices, "-g is not necessary if --goPath is already set")
}
} else if golang || goName != gen.DefaultName{
} else if golang || goName != gen.DefaultName {
path := filepath.Join(defaultOutputPath, Go)
ls.GoPath = &path
}
Expand Down