Merged
Conversation
bastelfreak
previously approved these changes
Sep 8, 2021
smortex
force-pushed
the
fix/check-for-nil-value
branch
from
918b3f8 to
eb8f10c
Compare
runejuhl
previously approved these changes
Sep 8, 2021
bastelfreak
previously approved these changes
Sep 8, 2021
The options hash passed to Facter::Core::Execution.execute expect a `time_limit`, not a `limit`: https://www.rubydoc.info/gems/facter/Facter/Core/Execution#execute-class_method
When this fact was evaluated, an exception was raised: Error: Facter: Error while resolving custom fact fact='docker_worker_join_token', resolution='<anonymous>': private method `execute' called for Facter::Util::Resolution:Class Switch from Facter::Util::Resolution to Facter::Core::Execution and set a time limit of 90s to match the rest of the file.
This make it easier to debug failing unit tests.
smortex
force-pushed
the
fix/check-for-nil-value
branch
2 times, most recently
from
eb8f10c to
f756598
Compare
bastelfreak
approved these changes
Sep 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #770 which fixed a bunch of issues but there are a few more addressed here:
undefined methodmatch?' for nil:NilClass`Facter::Core::Execution.executeinstead of the deprecatedFacter::Core::Execution.exec;Facter::Core::Execution.executeinstead of the privateFacter::Util::Resolution.execute.Fixes #769
Fixes #771