Refactor MySQL bindings and client packages.#232
Merged
apenney merged 1 commit intopuppetlabs:masterfrom Jul 23, 2013
apenney:refactor-round-1
Merged
Refactor MySQL bindings and client packages.#232apenney merged 1 commit intopuppetlabs:masterfrom apenney:refactor-round-1
apenney merged 1 commit intopuppetlabs:masterfrom
apenney:refactor-round-1
Conversation
The current MySQL module is hard to modify, test, and drop in replacement components to. This work starts out by refactoring the bindings support in MySQL to a completely seperate bindings class in order to reduce the amount of parameters in the main class for a feature that is infrequently used. In addition to this start the movement of client configuration and packages to the mysql::client::* namespace.
apenney
pushed a commit
that referenced
this pull request
Jul 23, 2013
Refactor MySQL bindings and client packages.
Contributor
There was a problem hiding this comment.
This requires puppet 2.7+. Is this change intentional or just an oversight?
Contributor
Author
There was a problem hiding this comment.
I wouldn't say it's an intentional change but we're no longer actively supporting 2.6 in any way. It's beyond end of life and we're no longer testing modules against it or ensuring that it stays working. We'll take minor patches like dropping the last comma, but we're.. actively pushing for people to move up. :)
Contributor
There was a problem hiding this comment.
Since it's a minor patch, I created #235. We also started the discussion about supporting 2.6 in the foreman installer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current MySQL module is hard to modify, test, and drop in
replacement components to. This work starts out by refactoring
the bindings support in MySQL to a completely seperate bindings
class in order to reduce the amount of parameters in the main
class for a feature that is infrequently used.
In addition to this start the movement of client configuration
and packages to the mysql::client::* namespace.