Method for loading .my.cnf file is changed from "defaults-file" to "defaults-extra-file" (mysql option)#367
Merged
apenney merged 2 commits intopuppetlabs:masterfrom Nov 12, 2013
Merged
Conversation
Contributor
|
This is a good idea, however, you will need to adapt the failing tests. |
Should load the .my.cnf file with "--defaults-extra-file" instead of "--defaults-file". This is necessary if we have global my.cnf file but we want to use both of them.
Contributor
Author
|
Changes are done. Can you merge it now? Tamas |
Contributor
|
still missing grants: https://travis-ci.org/puppetlabs/puppetlabs-mysql/jobs/13817136#L254 |
Contributor
Author
|
And a new try ... |
Contributor
|
ugh... we should create an issue for that, they are deprecated. |
Contributor
|
can you please squash the last two commits please? |
Contributor
|
Nice! Any chance you can squash your commits down so we just have 1-2? Once that's done I'll get this tested and merged. Thanks! |
Added "require" to the global mysql.rb file like in the other provider files. defaults-file changed to defaults-extra-file in all the database_* (old) providers, the same as in the mysql_* providers. Changed defaults-file to defaults-extra-file in all test files
Contributor
Author
|
Done |
apenney
pushed a commit
that referenced
this pull request
Nov 12, 2013
Method for loading .my.cnf file is changed from "defaults-file" to "defaults-extra-file" (mysql option)
Contributor
|
Thanks for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The providers should load the .my.cnf file with "--defaults-extra-file" instead of "--defaults-file". This is necessary if we have global my.cnf file but we want to use both of them.