Define service_hasstatus/hasrestart for Amazon Linux#81
Merged
tphoney merged 1 commit intopuppetlabs:masterfrom Mar 20, 2017
Merged
Define service_hasstatus/hasrestart for Amazon Linux#81tphoney merged 1 commit intopuppetlabs:masterfrom
tphoney merged 1 commit intopuppetlabs:masterfrom
Conversation
Ensures compatibility with strict variables, and copies "RedHat" values as AL is roughly based on EL6.
ekohl
approved these changes
Oct 23, 2016
Contributor
|
any movement here? |
tphoney
reviewed
Nov 24, 2016
| $service_name = 'xinetd' | ||
| $service_hasrestart = true | ||
| $service_hasstatus = false | ||
| $service_restart = undef |
Contributor
There was a problem hiding this comment.
service_hasrestart is set to true, but there is no restart command defined.
Contributor
Author
There was a problem hiding this comment.
@tphoney the provider default should suffice (i.e. probably service xinetd restart for this OS + provider), no custom command should be needed
Contributor
|
any movement here? |
Contributor
|
Thanks for the fix, apologies for the tardiness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures compatibility with strict variables, and copies "RedHat" values
as AL is roughly based on EL6.