This repository was archived by the owner on Aug 4, 2023. It is now read-only.
Improvements for v5 - #11
Merged
Merged
Conversation
jamesdbrock
force-pushed
the
event-remove
branch
2 times, most recently
from
January 11, 2023 13:19
85387d5 to
433d7db
Compare
jamesdbrock
marked this pull request as ready for review
January 11, 2023 13:24
jamesdbrock
force-pushed
the
event-remove
branch
2 times, most recently
from
January 15, 2023 05:37
51bedbe to
b9fc445
Compare
jamesdbrock
marked this pull request as draft
January 15, 2023 05:38
jamesdbrock
force-pushed
the
event-remove
branch
7 times, most recently
from
January 15, 2023 06:17
0356c48 to
4482617
Compare
jamesdbrock
marked this pull request as ready for review
January 15, 2023 06:19
jamesdbrock
force-pushed
the
event-remove
branch
2 times, most recently
from
January 15, 2023 06:28
c9bb3d5 to
2e060f4
Compare
- Change readers to return record instead of `Tuple`. - Cleanup event handlers. - Complete reads when stream is closed. - New `Internal` functions.
jamesdbrock
force-pushed
the
event-remove
branch
from
January 15, 2023 11:08
2e060f4 to
dedb52f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements for v5
Tuple.Internalfunctions.