Element.matches + Element.closest#39
Conversation
d033aa7 to
b0bd845
Compare
|
Yeah, we could perhaps move the |
|
I getcha. How do you, @garyb, recommend fixing this build error? * Building project in /home/runner/work/purescript-web-dom/purescript-web-dom
[1/1 DuplicateSelectiveImport] src/Web/DOM/Element.purs:57:1
57 import Web.DOM.ParentNode (ParentNode, QuerySelector)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
There is an existing import of Web.DOM.ParentNode, consider merging the import lists |
| import Web.DOM.Internal.Types (Element, HTMLCollection, Node) | ||
| import Web.DOM.NonDocumentTypeChildNode (NonDocumentTypeChildNode) | ||
| import Web.DOM.ParentNode (ParentNode) | ||
| import Web.DOM.ParentNode (QuerySelector) as Exports |
There was a problem hiding this comment.
| import Web.DOM.ParentNode (QuerySelector) as Exports |
There was a problem hiding this comment.
Don't I still want to export it for convenience? (Sorry, I don't think I understand)
There was a problem hiding this comment.
It’s also re-exported on the next line — this is the source of the duplicate error.
1296f09 to
18b5845
Compare
|
I added |
18b5845 to
060074a
Compare
|
Thanks! |
…rs-warnings Fix `HiddenConstructors` warnings
fixes #38. Copied
querySelector-isms. It's looking like perhapsQuerySelectordoesn't make a lot of sense stuck insideParentNodewith this though. 🤔Prerequisites
purescript-webprojects. Although MDN is a great resource, it is not a suitable reference for this project.https://dom.spec.whatwg.org/#dom-element-matches
https://dom.spec.whatwg.org/#dom-element-closest
Description of the change
Add missing Element feature
Checklist: